Handle case where Conduit repository.query doesn't send a value
ClosedPublic
Actions

Authored by dereckson on Mar 29 2018, 21:53.

Details

Reviewers

dereckson

Maniphest Tasks

T1387: ErrorException: count(): Parameter must be an array or an object that implements Countable

Commits

rNOTIF7b63e4d9345a: Handle case where Conduit repository.query doesn't send a value

Summary

Fix the following error in NotifyNewCommitsToDiffusion:
count(): Parameter must be an array or an object that implements Countable

Fixes T1387.

Test Plan

Tested by NotifyNewCommitsToDiffusionTest::testHandle

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

T1387

Build Status

Buildable 2413
Build 2661: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 29 2018, 21:53

dereckson created this revision.

Harbormaster completed remote builds in B2413: Diff 3925.Mar 29 2018, 21:53

dereckson accepted this revision.Mar 29 2018, 21:54

This revision is now accepted and ready to land.Mar 29 2018, 21:54

Closed by commit rNOTIF7b63e4d9345a: Handle case where Conduit repository.query doesn't send a value (authored by dereckson). · Explain WhyMar 29 2018, 21:54

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Jobs/

NotifyNewCommitsToDiffusion.php

2 lines

Diff 3925

View Options

app/Jobs/NotifyNewCommitsToDiffusion.php

Handle case where Conduit repository.query doesn't send a valueClosedPublicActions