Paths

Table of Contentst

Differential D1545

Ensure lines are at most 80 characters
ClosedPublic
Actions

Authored by dereckson on Mar 30 2018, 00:00.

Details

Reviewers

dereckson

Commits

rNOTIF1523ea67ce77: Ensure lines are at most 80 characters

Summary

Several strategies have been used:

group namespaces use declarations
heredoc and newdoc strings
prune non informative comments or switch them to PHP 7 type hints
break lines

References:

https://wiki.php.net/rfc/group_use_declarations
http://php.net/manual/en/language.types.string.php (heredoc, newdoc)

Test Plan

phpcs with Generic.Files.LineLength sniff

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 30 2018, 00:00

dereckson created this revision.

Harbormaster completed remote builds in B2423: Diff 3942.Mar 30 2018, 00:00

dereckson edited the test plan for this revision. (Show Details)Mar 30 2018, 00:01

dereckson added a reviewer: dereckson.

dereckson edited the summary of this revision. (Show Details)

Tests too

Harbormaster completed remote builds in B2424: Diff 3943.Mar 30 2018, 00:21

Don't touch porcelain Phabricator non refactored code, tests and code don't agree on return types

Harbormaster completed remote builds in B2426: Diff 3946.Mar 30 2018, 00:40

dereckson accepted this revision.Mar 30 2018, 00:41

This revision is now accepted and ready to land.Mar 30 2018, 00:41

Closed by commit rNOTIF1523ea67ce77: Ensure lines are at most 80 characters (authored by dereckson). · Explain WhyMar 30 2018, 00:41

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

app/

Actions/

AMQPAction.php

6 lines

ActionError.php

5 lines

Analyzers/

BasePayloadAnalyzer.php

16 lines

GitHub/

Events/

Event.php

4 lines

WithRepoAndBranch.php

16 lines

GitHubPayloadAnalyzer.php

6 lines

ItemGroupMapping.php

5 lines

Phabricator/

PhabricatorPayloadAnalyzerConfiguration.php

3 lines

Config/

Features.php

2 lines

Reporting/

BaseReportEntry.php

15 lines

ServiceReportEntry.php

5 lines

Services/

Services.php

11 lines

Console/

Commands/

NotificationsPayload.php

23 lines

PhabricatorProjectsMap.php

4 lines

Kernel.php

2 lines

Http/

Controllers/

Gate/

GateController.php

7 lines

routes.php

5 lines

Jobs/

FireDockerHubNotification.php

5 lines

FireGitHubNotification.php

6 lines

FireJenkinsNotification.php

5 lines

FirePhabricatorNotification.php

5 lines

NotifyNewCommitsToDiffusion.php

8 lines

SendMessageToBroker.php

6 lines

Listeners/

AMQPEventListener.php

14 lines

NotificationListener.php

4 lines

Notifications/

DockerHubNotification.php

6 lines

GitHubNotification.php

9 lines

JenkinsNotification.php

3 lines

Phabricator/

PhabricatorAPI.php

30 lines

PhabricatorStory.php

28 lines

ProjectsMap.php

23 lines

Providers/

EventServiceProvider.php

6 lines

ReportServiceProvider.php

16 lines

RouteServiceProvider.php

6 lines

tests/

Console/

Commands/

ConfigShowTest.php

4 lines

NotificationsPayloadTest.php

2 lines

PhabricatorProjectsMapTest.php

3 lines

KernelTest.php

11 lines

Diff 3947

View Options

app/Actions/AMQPAction.php

View Options

app/Actions/ActionError.php

View Options

app/Analyzers/BasePayloadAnalyzer.php

View Options

app/Analyzers/GitHub/Events/Event.php

View Options

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

View Options

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

View Options

app/Analyzers/ItemGroupMapping.php

View Options

app/Analyzers/Phabricator/PhabricatorPayloadAnalyzerConfiguration.php

View Options

app/Config/Features.php

View Options

app/Config/Reporting/BaseReportEntry.php

View Options

app/Config/Reporting/ServiceReportEntry.php

View Options

app/Config/Services/Services.php

View Options

app/Console/Commands/NotificationsPayload.php

View Options

app/Console/Commands/PhabricatorProjectsMap.php

View Options

app/Console/Kernel.php

View Options

app/Http/Controllers/Gate/GateController.php

View Options

app/Http/routes.php

View Options

app/Jobs/FireDockerHubNotification.php

View Options

app/Jobs/FireGitHubNotification.php

View Options

app/Jobs/FireJenkinsNotification.php

View Options

app/Jobs/FirePhabricatorNotification.php

View Options

app/Jobs/NotifyNewCommitsToDiffusion.php

View Options

app/Jobs/SendMessageToBroker.php

View Options

app/Listeners/AMQPEventListener.php

View Options

app/Listeners/NotificationListener.php

View Options

app/Notifications/DockerHubNotification.php

View Options

app/Notifications/GitHubNotification.php

View Options

app/Notifications/JenkinsNotification.php

View Options

app/Phabricator/PhabricatorAPI.php

View Options

app/Phabricator/PhabricatorStory.php

View Options

app/Phabricator/ProjectsMap.php

View Options

app/Providers/EventServiceProvider.php

View Options

app/Providers/ReportServiceProvider.php

View Options

app/Providers/RouteServiceProvider.php

View Options

tests/Console/Commands/ConfigShowTest.php

View Options

tests/Console/Commands/NotificationsPayloadTest.php

View Options

tests/Console/Commands/PhabricatorProjectsMapTest.php

View Options

tests/Console/KernelTest.php

Ensure lines are at most 80 charactersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 3947

app/Actions/AMQPAction.php

app/Actions/ActionError.php

app/Analyzers/BasePayloadAnalyzer.php

app/Analyzers/GitHub/Events/Event.php

app/Analyzers/GitHub/Events/WithRepoAndBranch.php

app/Analyzers/GitHub/GitHubPayloadAnalyzer.php

app/Analyzers/ItemGroupMapping.php

app/Analyzers/Phabricator/PhabricatorPayloadAnalyzerConfiguration.php

app/Config/Features.php

app/Config/Reporting/BaseReportEntry.php

app/Config/Reporting/ServiceReportEntry.php

app/Config/Services/Services.php

app/Console/Commands/NotificationsPayload.php

app/Console/Commands/PhabricatorProjectsMap.php

app/Console/Kernel.php

app/Http/Controllers/Gate/GateController.php

app/Http/routes.php

app/Jobs/FireDockerHubNotification.php

app/Jobs/FireGitHubNotification.php

app/Jobs/FireJenkinsNotification.php

app/Jobs/FirePhabricatorNotification.php

app/Jobs/NotifyNewCommitsToDiffusion.php

app/Jobs/SendMessageToBroker.php

app/Listeners/AMQPEventListener.php

app/Listeners/NotificationListener.php

app/Notifications/DockerHubNotification.php

app/Notifications/GitHubNotification.php

app/Notifications/JenkinsNotification.php

app/Phabricator/PhabricatorAPI.php

app/Phabricator/PhabricatorStory.php

app/Phabricator/ProjectsMap.php

app/Providers/EventServiceProvider.php

app/Providers/ReportServiceProvider.php

app/Providers/RouteServiceProvider.php

tests/Console/Commands/ConfigShowTest.php

tests/Console/Commands/NotificationsPayloadTest.php

tests/Console/Commands/PhabricatorProjectsMapTest.php

tests/Console/KernelTest.php

Ensure lines are at most 80 characters
ClosedPublic
Actions

Revision Contents
Changeset List