Page MenuHomeDevCentral

Ensure lines are at most 80 characters
ClosedPublic

Authored by dereckson on Mar 30 2018, 00:00.
Tags
None
Referenced Files
F3750291: D1545.id.diff
Sat, Nov 16, 23:35
F3750247: D1545.diff
Sat, Nov 16, 23:07
Unknown Object (File)
Tue, Nov 12, 10:52
Unknown Object (File)
Sat, Nov 9, 16:42
Unknown Object (File)
Fri, Nov 8, 23:19
Unknown Object (File)
Fri, Nov 8, 23:19
Unknown Object (File)
Fri, Nov 8, 23:19
Unknown Object (File)
Fri, Nov 8, 23:19
Subscribers
None

Details

Summary

Several strategies have been used:

  • group namespaces use declarations
  • heredoc and newdoc strings
  • prune non informative comments or switch them to PHP 7 type hints
  • break lines

References:

Test Plan

phpcs with Generic.Files.LineLength sniff

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
wrap-long-lines (branched from master)
Build Status
Buildable 2424
Build 2672: arc lint + arc unit

Event Timeline

dereckson created this revision.
dereckson added a reviewer: dereckson.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the summary of this revision. (Show Details)

Don't touch porcelain Phabricator non refactored code, tests and code don't agree on return types

This revision is now accepted and ready to land.Mar 30 2018, 00:41
This revision was automatically updated to reflect the committed changes.