Get debug information for null messages from notifications center
ClosedPublic
Actions

Authored by dereckson on Mar 30 2018, 23:44.

Details

Reviewers

dereckson

Maniphest Tasks

T1253: Merge task event in Phabricator produces a null text

Commits

rVIPERed768f660664: Get debug information for null messages from notifications center

Summary

Sometimes Wearg writes:
23:10:13 < Wearg> null

This change allows to investigate on what happens.

Ref T1253

Test Plan

The next null message shouldn't appear on the channel.

Partyline should print the raw notification.

Diff Detail

Repository

rVIPER ViperServ scripts

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

production

Build Status

Buildable 2444
Build 2692: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mar 30 2018, 23:44

dereckson created this revision.

Harbormaster completed remote builds in B2443: Diff 3975.Mar 30 2018, 23:44

Use the same routing key than AMQPEventListener::getNotificationRoutingKey

Harbormaster completed remote builds in B2444: Diff 3976.Mar 30 2018, 23:52

s/message/text

Harbormaster completed remote builds in B2455: Diff 3995.Apr 2 2018, 01:06

dereckson accepted this revision.Apr 2 2018, 01:06

This revision is now accepted and ready to land.Apr 2 2018, 01:06

Closed by commit rVIPERed768f660664: Get debug information for null messages from notifications center (authored by dereckson). · Explain WhyApr 2 2018, 01:07

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Wearg/

Notifications.tcl

8 lines

Diff 3976

View Options

Get debug information for null messages from notifications centerClosedPublicActions