Differential D16

Detect JSON issue parsing workspace configuration file.
ClosedPublic
Actions

Authored by dereckson on Jul 9 2015, 23:29.

Details

Reviewers

dereckson

Maniphest Tasks

T465: When a workspace mail configuration JSON file is malformed, throw an explicit error message

Commits

rOBSIDIAN37e7767a8264: Detect JSON issue parsing workspace configuration file.

Summary

If the workspace configuration file has a JSON issue, we detect it and print
the result of json_last_error_message() to help the admin to solve the issue.

Fixes T465.

Test Plan

fortune > workspaces/quux/workspace.conf
Got the error message on http://obsidian51.trantorium.com/quux

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

fix-WorkspaceConfigurationFileJsonMalformed

Event Timeline

dereckson updated this revision to Diff 30.Jul 9 2015, 23:29

dereckson retitled this revision from to Detect JSON issue parsing workspace configuration file..

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson added a task: T465: When a workspace mail configuration JSON file is malformed, throw an explicit error message.

dereckson accepted this revision.Jul 9 2015, 23:30

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jul 9 2015, 23:30

Closed by commit rOBSIDIAN37e7767a8264: Detect JSON issue parsing workspace configuration file. (authored by dereckson, committed by dereckson). · Explain WhyJul 9 2015, 23:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

includes/

workspaces/

WorkspaceConfiguration.php

9 lines

Diff 30

View Options

includes/workspaces/WorkspaceConfiguration.php

Detect JSON issue parsing workspace configuration file.ClosedPublicActions