Page MenuHomeDevCentral

Map the Phabricator credentials ID
ClosedPublic

Authored by dereckson on Sep 12 2018, 09:56.

Details

Summary

Currently, Phabricator credentials are described by number.
This solution isn't the best for maintenance and doesn't allow secrets
replacement easily (what if we want to hunt the number 2 in the repo?).

This change provides a new pillar entry, zr_credentials, to map the IDs
to dictionary keys.

The Zemke-Rhyne execution module is updated to support keys expressions
(with . or : as separatator) in addition to numeric values.

The key dotted format has been selected to be stable, as the key would
also be a valid expression to fetch the secret in other stores, like Vault.

Ref T1425

Test Plan

salt equatower zr.get_username nasqueron.cachet.mysql

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Sep 12 2018, 09:56
dereckson created this revision.
dereckson accepted this revision.Sep 12 2018, 09:57
dereckson marked an inline comment as done.
dereckson added inline comments.
_modules/zr.py
20–21

Style independant fix

This revision is now accepted and ready to land.Sep 12 2018, 09:57
This revision was automatically updated to reflect the committed changes.