Page MenuHomeDevCentral

Map the Phabricator credentials ID
ClosedPublic

Authored by dereckson on Sep 12 2018, 09:56.
Tags
None
Referenced Files
F3775994: D1738.diff
Sun, Nov 24, 20:43
Unknown Object (File)
Tue, Nov 19, 18:07
Unknown Object (File)
Mon, Nov 18, 10:12
Unknown Object (File)
Tue, Nov 12, 07:14
Unknown Object (File)
Tue, Nov 12, 04:55
Unknown Object (File)
Tue, Nov 12, 03:49
Unknown Object (File)
Mon, Nov 11, 20:29
Unknown Object (File)
Sun, Nov 10, 09:54
Subscribers
None

Details

Summary

Currently, Phabricator credentials are described by number.
This solution isn't the best for maintenance and doesn't allow secrets
replacement easily (what if we want to hunt the number 2 in the repo?).

This change provides a new pillar entry, zr_credentials, to map the IDs
to dictionary keys.

The Zemke-Rhyne execution module is updated to support keys expressions
(with . or : as separatator) in addition to numeric values.

The key dotted format has been selected to be stable, as the key would
also be a valid expression to fetch the secret in other stores, like Vault.

Ref T1425

Test Plan

salt equatower zr.get_username nasqueron.cachet.mysql

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
zr (branched from master)
Build Status
Buildable 2711
Build 2959: arc lint + arc unit

Event Timeline

dereckson created this revision.
dereckson marked an inline comment as done.
dereckson added inline comments.
_modules/zr.py
20

Style independant fix

This revision is now accepted and ready to land.Sep 12 2018, 09:57
This revision was automatically updated to reflect the committed changes.