Page MenuHomeDevCentral

Refactor Services as a Facade to a more generic Services class
ClosedPublic

Authored by dereckson on Jan 8 2016, 19:41.
Tags
None
Referenced Files
F10160459: D180.id430.diff
Sat, Jun 21, 08:36
F10160446: D180.id429.diff
Sat, Jun 21, 08:36
F10160436: D180.id428.diff
Sat, Jun 21, 08:35
F10158581: D180.diff
Sat, Jun 21, 05:14
Unknown Object (File)
Thu, Jun 19, 05:40
Unknown Object (File)
Tue, Jun 17, 16:05
Unknown Object (File)
Fri, Jun 13, 17:00
Unknown Object (File)
Fri, Jun 13, 00:18
Subscribers
None

Details

Summary

Currently, Services were a bag of static methods to read
credentials.json.

We now provide:

  • a generic and autonomous Services class
  • a Service class to represent a credentials.json entry
  • a services provider to register our application instance of Services
  • a Services facade, as a drop-in substitute for the former Services
Test Plan

Send a payload request.

Run commands php artisan config:show and php artisan phabricator:projectsmap.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson retitled this revision from to Refactor Services as a Facade to a more generic Services class.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.

Dead code in GateController

dereckson edited edge metadata.

rm dead code

dereckson added inline comments.
app/Services/Services.php
16

To initialize?

16

Could it be private?

22

Dead constructor.

dereckson marked 3 inline comments as done.

Improve Services class

app/Services/Services.php
16

No it couldn't, per JsonMapper.

dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 8 2016, 19:55
This revision was automatically updated to reflect the committed changes.