Page MenuHomeDevCentral

[Channel] Ensure we've a video title before print it
ClosedPublic

Authored by dereckson on Jan 9 2016, 01:34.
Tags
None
Referenced Files
F3767124: D191.diff
Fri, Nov 22, 22:34
F3764192: D191.diff
Fri, Nov 22, 04:34
Unknown Object (File)
Sun, Nov 10, 09:01
Unknown Object (File)
Sat, Nov 9, 14:53
Unknown Object (File)
Wed, Nov 6, 07:28
Unknown Object (File)
Wed, Nov 6, 05:47
Unknown Object (File)
Wed, Nov 6, 03:31
Unknown Object (File)
Sat, Nov 2, 09:54
Subscribers
None

Details

Summary

Sometimes, a video from Vimeo doesn't have a title.

Before, "PRIVMSG #channel :" were sent to the IRC server, with
an extraneous command sent to the server.

With D166 and a new prefix, we had a "[Vid] " line printed.

We now check the length of the video title.

Issue reported by popolon.

Test Plan

Tested on Freenode #fauve.

Diff Detail

Repository
rVIPERSERV ViperServ scripts [legacy Mercurial repo]
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vimeo-fix (bookmark) on default (branch)
Build Status
Buildable 239
Build 239: arc lint + arc unit

Event Timeline

dereckson retitled this revision from to [Channel] Ensure we've a video title before print it.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Jan 9 2016, 01:35
This revision was automatically updated to reflect the committed changes.