Page MenuHomeDevCentral

Migrate to more modern and modular PHP 7.2 code
Changes PlannedPublic

Authored by dereckson on Oct 14 2018, 03:17.
Tags
None
Referenced Files
F2742914: D1920.id4849.diff
Thu, Mar 28, 07:02
F2741801: D1920.diff
Thu, Mar 28, 02:09
Unknown Object (File)
Sat, Mar 23, 02:01
Unknown Object (File)
Tue, Mar 19, 00:09
Unknown Object (File)
Mon, Mar 18, 03:52
Unknown Object (File)
Thu, Mar 14, 03:26
Unknown Object (File)
Mon, Mar 11, 00:12
Unknown Object (File)
Mon, Mar 11, 00:12
Subscribers
None

Details

Reviewers
dereckson
Summary

Transfer the utility methods responsibility to Keruald OmniTools.

Use PSR-4 namespace Keruald\Core for main features.
The configuration, error global functions and not yet migrated
functions are kept.

Offer a transparent migration path to convert user passwords from legacy MD5
to a modern hash (by default, under PHP 7.2, the default is Argon2i) when
they log in successfully.

Use type hints for signature methods.

Test Plan

Build a small site with a login form and some MD5 password to migrate.

Dump session.

Diff Detail

Repository
rK Keruald legacy core libraries
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
migration (branched from master)
Build Status
Buildable 2984
Build 3232: arc lint + arc unit

Event Timeline

dereckson created this revision.

Use mysqli classes from root namespace

dereckson added inline comments.
src/Database/Database.php
68

Class MUST be fully qualified with namespace.

Not sure the best strategy for this change.

I've archived the repository on GitHub, to create a more flexible system based on:

  • keruald/omnitools for helpers functions (rKOT)
  • keruald/database (rDB)
  • keruald/application to create a web application, repository to create

The MD5 to salted hash migration path is pretty important here and should be extracted and promoted to legacy web applications still using that hash.

Obsidian Workspaces has a better approach for the session code I think (rOBSIDIAN).