Page MenuHomeDevCentral

Always set an aliases value to pass to nginx config template
ClosedPublic

Authored by dereckson on Oct 15 2018, 12:33.

Details

Summary

When a container doesn't have any alias for hostname,
an empty string is passed to the nginx configuration template.

This is a follow-up for af0a1983.

Test Plan

Run salt equatower state.apply roles/paas-docker/nginx/config
then look the Phabricator containers vhosts (only DevCentral has aliases).

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Oct 15 2018, 12:33
dereckson created this revision.
dereckson updated this revision to Diff 4866.Oct 15 2018, 12:37

Use Jinja2 filter to avoid if/else block

dereckson accepted this revision.Oct 15 2018, 12:39
dereckson retitled this revision from Explicitly give a null value to aliases when there isn't any to Always set an aliases value to pass to nginx config template.
dereckson edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Oct 15 2018, 12:39
This revision was automatically updated to reflect the committed changes.