Always set an aliases value to pass to nginx config template
ClosedPublic
Actions

Authored by dereckson on Oct 15 2018, 12:33.

Details

Reviewers

dereckson

Commits

rOPS4cac446f1c3d: Always set an aliases value to pass to nginx config template

Summary

When a container doesn't have any alias for hostname,
an empty string is passed to the nginx configuration template.

This is a follow-up for af0a1983.

Test Plan

Run salt equatower state.apply roles/paas-docker/nginx/config
then look the Phabricator containers vhosts (only DevCentral has aliases).

Diff Detail

Repository

rOPS Nasqueron Operations

Lint

Lint Passed

Unit

No Test Coverage

Branch

fix-nginx-config (branched from master)

Build Status

Buildable 2995
Build 3243: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Oct 15 2018, 12:33

dereckson created this revision.

Harbormaster completed remote builds in B2994: Diff 4865.Oct 15 2018, 12:33

Use Jinja2 filter to avoid if/else block

Harbormaster completed remote builds in B2995: Diff 4866.Oct 15 2018, 12:37

dereckson accepted this revision.Oct 15 2018, 12:39

dereckson retitled this revision from Explicitly give a null value to aliases when there isn't any to Always set an aliases value to pass to nginx config template.

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Oct 15 2018, 12:39

Closed by commit rOPS4cac446f1c3d: Always set an aliases value to pass to nginx config template (authored by dereckson). · Explain WhyOct 15 2018, 12:39

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

roles/

paas-docker/

nginx/

config.sls

4 lines

Diff 4866

View Options

roles/paas-docker/nginx/config.sls

Always set an aliases value to pass to nginx config templateClosedPublicActions