Paths

Table of Contentst

Differential D197

Payload full test, with a blackhole broker
ClosedPublic
Actions

Authored by dereckson on Jan 9 2016, 05:33.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIFc89945f725f8: Payload full test, with a blackhole broker

Summary

Tests a more realistic scenario where:

a payload is received
events are fully dispatched

We mock the broker to allow to run the test without one.

This bumps the dependency to Keruald Broker from 0.1 to 0.2.

Test Plan

phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

No Lint Coverage

Unit

Tests Passed

Branch

arcpatch-D197

Build Status

Buildable 258
Build 258: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 468.Jan 9 2016, 05:33

dereckson retitled this revision from to WIP: Payload full test.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

We need to mock the broker.

Code to mock

Broker::setExchangeTarget($this->target)
    ->routeTo($this->routingKey)
    ->sendMessage($this->message);

Mock proposal

$mock = Mockery('Keruald\Broker\AMQPBroker');

$mock->shouldReceive('setExchangeTarget'); // TODO: return $this, not null
$mock->shouldReceive('routeTo');
$mock->shouldReceive('sendMessage');

$this->app->instance('broker', $mock);

Reference: http://docs.mockery.io/en/latest/reference/demeter_chains.html

Rebased against master

We can mock, or use the blackhole.

Use BlackholeBroker

dereckson accepted this revision.Jan 9 2016, 18:12

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 9 2016, 18:12

dereckson retitled this revision from WIP: Payload full test to Payload full test, with a blackhole broker.Jan 9 2016, 18:13

dereckson updated this object.

dereckson edited edge metadata.

dereckson added projects: Notifications center, Keruald.

Closed by commit rNOTIFc89945f725f8: Payload full test, with a blackhole broker (authored by dereckson, committed by dereckson). · Explain WhyJan 9 2016, 18:13

This revision was automatically updated to reflect the committed changes.

In D197#3104, @dereckson wrote:

We need to mock the broker.

Code to mock

Broker::setExchangeTarget($this->target)
    ->routeTo($this->routingKey)
    ->sendMessage($this->message);

Mock proposal

$mock = Mockery('Keruald\Broker\AMQPBroker');

$mock->shouldReceive('setExchangeTarget'); // TODO: return $this, not null
$mock->shouldReceive('routeTo');
$mock->shouldReceive('sendMessage');

$this->app->instance('broker', $mock);

Reference: http://docs.mockery.io/en/latest/reference/demeter_chains.html

For reference, the following method mocks correctly the broker:

Working mock code

$mock = Mockery::mock('Keruald\Broker\Broker');
$mock->shouldReceive('connect');
$mock->shouldReceive('setExchangeTarget->routeTo->sendMessage');

$this->app->instance('broker', $mock);