[DO NOT MERGE] Use Laravel WithoutEvents test trait
AbandonedPublic
Actions

Authored by dereckson on Jan 9 2016, 15:16.

Details

Reviewers: None

Summary

D195 introduced TestCase::disableEvents, as the Laravel methods
MocksApplicationServices::expectEvents and ::withoutEvents don't
mock the listen method.

We can use the Laravel implementation now it has been fixed at
the framework level.

Test Plan

phpunit --no-coverage

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

use-laravel-events-mock

Build Status

Buildable 261
Build 261: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 471.Jan 9 2016, 15:16

dereckson retitled this revision from to [DO NOT MERGE] Use Laravel WithoutEvents test trait.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

Tests work with this laravel/framework change: http://devcentral.nasqueron.org/differential/diff/472/

https://github.com/laravel/framework/pull/11788 upstream

Rebased.

Upstream not interested by the change, but provides a simpler solution.

TestCase::disableEvents()

$this->withoutEvents();
Events::shouldReceive('listen');

[RuntimeException]                                                                             
Error Output: PHP Fatal error:  Class 'Events' not found in /home/ubuntu/workspace/notificati  
ons/tests/TestCase.php on line 44

Revision Contents
Changeset List

Path

Size

tests/

Http/

Controllers/

GitHubGateControllerTest.php

2 lines

Diff 490

View Options

tests/Http/Controllers/GitHubGateControllerTest.php

[DO NOT MERGE] Use Laravel WithoutEvents test traitAbandonedPublicActions