Page MenuHomeDevCentral

Fix version regex
ClosedPublic

Authored by dereckson on Apr 22 2019, 08:03.

Details

Summary

Allow to use version pinning with the multiline output
of shellcheck --version.

Test Plan

arc lint --everything

Diff Detail

Repository
rSCL ShellCheck linter for Arcanist
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Apr 22 2019, 08:03
dereckson created this revision.
dereckson accepted this revision.Apr 22 2019, 08:04
This revision is now accepted and ready to land.Apr 22 2019, 08:04
dereckson added a comment.EditedApr 22 2019, 08:08

Can't repro directly through arc lint interaction the issue.

Probably best to add a unit test.

dereckson added a comment.EditedApr 22 2019, 08:27

Without the fix

$ arc unit --everything
   FAIL  ArcanistShellCheckLinterTestCase::testGetVersion
Assertion failed, expected 'false' (at ArcanistShellCheckLinterTestCase.php:9): The version can't be extracted from the binary output.

With the fix

$ arc unit
   PASS   35ms★ ArcanistShellCheckLinterTestCase::testGetVersion
dereckson updated this revision to Diff 5207.Apr 22 2019, 08:30

Adding unit tests

dereckson accepted this revision.Apr 22 2019, 08:30
Closed by commit rSCLb766ce7a240b: Fix version regex (authored by Derek Argueta <dereka@pinterest.com>, committed by dereckson). · Explain WhyApr 22 2019, 08:32
This revision was automatically updated to reflect the committed changes.