Page MenuHomeDevCentral

Fix version regex
ClosedPublic

Authored by dereckson on Apr 22 2019, 08:03.
Tags
None
Referenced Files
F57510471: D2064.diff
Thu, Nov 19, 20:19
F57209516: D2064.id5206.diff
Mon, Nov 16, 07:08
F57130575: D2064.id5208.diff
Sun, Nov 15, 03:45
F57130572: D2064.id5206.diff
Sun, Nov 15, 03:45
F57130569: D2064.id.diff
Sun, Nov 15, 03:45
F57130529: D2064.id5207.diff
Sun, Nov 15, 03:44
F56747461: D2064.id5207.diff
Sun, Nov 8, 22:41
F56712615: D2064.id5208.diff
Sun, Nov 8, 12:59
Subscribers
None

Details

Summary

Allow to use version pinning with the multiline output
of shellcheck --version.

Test Plan

arc lint --everything

Diff Detail

Repository
rSCL ShellCheck linter for Arcanist
Lint
Lint Passed
Unit
Tests Passed
Branch
dereka/fix-version-check
Build Status
Buildable 3216
Build 3465: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 22 2019, 08:04

Can't repro directly through arc lint interaction the issue.

Probably best to add a unit test.

Without the fix

$ arc unit --everything
   FAIL  ArcanistShellCheckLinterTestCase::testGetVersion
Assertion failed, expected 'false' (at ArcanistShellCheckLinterTestCase.php:9): The version can't be extracted from the binary output.

With the fix

$ arc unit
   PASS   35ms★ ArcanistShellCheckLinterTestCase::testGetVersion
This revision was automatically updated to reflect the committed changes.