Prune unreachable code
ClosedPublic
Actions

Authored by dereckson on Jan 28 2020, 07:58.

Tags

None

Referenced Files

	F54477661: D2160.id5445.diff
	Mon, Oct 19, 15:25

	F54477270: D2160.diff
	Mon, Oct 19, 15:15

	Unknown Object (File)
	Fri, Oct 16, 20:24

	Unknown Object (File)
	Tue, Oct 13, 07:09

	Unknown Object (File)
	Mon, Oct 12, 19:31

	Unknown Object (File)
	Mon, Oct 12, 18:23

	Unknown Object (File)
	Mon, Oct 12, 01:16

	Unknown Object (File)
	Sun, Oct 11, 12:16

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOT18b54a66e3d6: Prune unreachable code

Summary

Detected with phan.

This is a follow-up for be6443b8.

Test Plan

no op

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Passed

Unit

Test Failures

Branch

dead-code (branched from master)

Build Status

Buildable 3361
Build 3610: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/usr/home/dereckson/dev/keruald/omnitools/tests/Network/IPv4RangeTest.php

Event Timeline

dereckson requested review of this revision.Jan 28 2020, 07:58

dereckson created this revision.

dereckson accepted this revision.Jan 28 2020, 07:58

This revision is now accepted and ready to land.Jan 28 2020, 07:58

Harbormaster completed remote builds in B3361: Diff 5445.Jan 28 2020, 07:58

This revision was landed with ongoing or failed builds.Jan 28 2020, 07:58

Closed by commit rKOT18b54a66e3d6: Prune unreachable code (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOT18b54a66e3d6: Prune unreachable code.

Revision Contents
Changeset List

Path

Size

src/

Network/

IPv4Range.php

2 lines

Diff 5445

View Options

Prune unreachable codeClosedPublicActions