Page MenuHomeDevCentral

Address File and CodeFile inheritance issues
ClosedPublic

Authored by dereckson on Jan 28 2020, 08:53.
Tags
None
Referenced Files
F3750718: D2162.diff
Sun, Nov 17, 03:01
Unknown Object (File)
Tue, Nov 12, 23:34
Unknown Object (File)
Thu, Oct 31, 10:28
Unknown Object (File)
Mon, Oct 21, 12:24
Unknown Object (File)
Fri, Oct 18, 18:12
Unknown Object (File)
Fri, Oct 18, 03:20
Unknown Object (File)
Oct 17 2024, 02:19
Unknown Object (File)
Oct 16 2024, 19:59
Subscribers
None

Details

Summary

The File class also implemented include logic.

Actually, this code was the one used when object was instancied by
CodeFile::From(), as it returned a File and not a CodeFile instance.

That first issue masked another one, CodeFile included the file
by name, and not by full path.

Test Plan

Run tests

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Jan 28 2020, 08:54
This revision was landed with ongoing or failed builds.Jan 28 2020, 08:54
This revision was automatically updated to reflect the committed changes.