Paths

Table of Contentst

Differential D220

Prune not used namespaces.
ClosedPublic
Actions

Authored by dereckson on Jan 11 2016, 17:48.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF46a71ea7b2f3: Prune not used namespaces.

Summary

Log class is now only called from GateController, not the children.

This is a follow-up of D219 / rNOTIFcc622917e76d.

Test Plan

tail -f storage/logs/laravel.log && phpunit --no-coverage

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson updated this revision to Diff 519.Jan 11 2016, 17:48

dereckson retitled this revision from to Prune not used namespaces..

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/13/ (console: https://ci.nasqueron.org/job/test-notifications-phab/13/console)

dereckson edited the test plan for this revision. (Show Details)Jan 11 2016, 17:48

Build is green https://ci.nasqueron.org/job/test-notifications-phab/13/ for more details.

dereckson accepted this revision.Jan 11 2016, 17:52

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 11 2016, 17:52

Closed by commit rNOTIF46a71ea7b2f3: Prune not used namespaces. (authored by dereckson, committed by dereckson). · Explain WhyJan 11 2016, 17:52

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in rNOTIFcc622917e76d: GateController::logRequest refactoring.Jan 11 2016, 17:52

Revision Contents
Changeset List

Path

Size

app/

Http/

Controllers/

Gate/

DockerHubGateController.php

1 line

GitHubGateController.php

1 line

PhabricatorGateController.php

1 line

Diff 520

View Options

app/Http/Controllers/Gate/DockerHubGateController.php

View Options

app/Http/Controllers/Gate/GitHubGateController.php

View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Prune not used namespaces.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 520

app/Http/Controllers/Gate/DockerHubGateController.php

app/Http/Controllers/Gate/GitHubGateController.php

app/Http/Controllers/Gate/PhabricatorGateController.php

Prune not used namespaces.
ClosedPublic
Actions

Revision Contents
Changeset List