HomeDevCentral

GateController::logRequest refactoring

Description

GateController::logRequest refactoring

Summary:
Any gate without any specific requirement can call logRequest
without argument.

Other gates can pass an array with extra contextual data to log.

The log format doesn't change.

Test Plan: tail -n 10 -f storage/logs/laravel.log && phpunit

Reviewers: dereckson

Subscribers: alken-orin

Differential Revision: http://devcentral.nasqueron.org/D219

Details

Auditors
dereckson
Provenance
derecksonAuthored on
Differential Revision
D219: GateController::logRequest refactoring
Parents
rNOTIFf35ae0bbc5cf: Test full payload, without ActionsReport
Branches
Unknown
Tags
Unknown

Event Timeline

This commit introduced dead code, as the class Log is declared but never used.

/app/Http/Controllers/Gate/DockerHubGateController.php
6

Not used anymore.

/app/Http/Controllers/Gate/GitHubGateController.php
6

Not used anymore.

/app/Http/Controllers/Gate/PhabricatorGateController.php
6

Not used anymore.

dereckson marked 3 inline comments as done.

Concerns addressed by D220 / rNOTIF46a71ea7b2f3.