ClosedPublic
Actions

Authored by dereckson on Mar 18 2020, 01:02.

Tags

None

Referenced Files

	F2989651: D2285.id5758.diff
	Sat, May 25, 12:53

	Unknown Object (File)
	Tue, May 21, 03:18

	Unknown Object (File)
	Thu, May 16, 20:56

	Unknown Object (File)
	Tue, May 14, 21:35

	Unknown Object (File)
	Mon, May 13, 02:04

	Unknown Object (File)
	Sun, May 12, 04:53

	Unknown Object (File)
	Sun, May 12, 04:53

	Unknown Object (File)
	Sun, May 12, 04:53

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final /

Summary

If https://domain.tld/ was parsed correctly, https://domain.tld
wasn't.

Test Plan

This change adds unit tests to catch the issue, and fixes it.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 18 2020, 01:02

dereckson created this revision.

Harbormaster completed remote builds in B3549: Diff 5756.Mar 18 2020, 01:02

Restore removed by error test

Harbormaster completed remote builds in B3550: Diff 5757.Mar 18 2020, 01:24

dereckson accepted this revision.Mar 18 2020, 01:24

This revision is now accepted and ready to land.Mar 18 2020, 01:24

Closed by commit rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final / (authored by dereckson). · Explain WhyMar 18 2020, 02:27

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final /.

Revision Contents
Changeset List

Path

Size

src/

HTTP/

URL.php

29 lines

tests/

HTTP/

URLTest.php

10 lines

Diff 5758

View Options

src/HTTP/URL.php