Differential D2285

Parse correctly https://domain.tld without query or final /
ClosedPublic
Actions

Authored by dereckson on Mar 18 2020, 01:02.

Tags

None

Subscribers

None

Details

Reviewers

Commits

rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final /

Summary

If https://domain.tld/ was parsed correctly, https://domain.tld
wasn't.

Test Plan

This change adds unit tests to catch the issue, and fixes it.

Diff Detail

Repository

rKOT Keruald OmniTools

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson requested review of this revision.Mar 18 2020, 01:02

dereckson created this revision.

Harbormaster completed remote builds in B3549: Diff 5756.Mar 18 2020, 01:02

Restore removed by error test

Harbormaster completed remote builds in B3550: Diff 5757.Mar 18 2020, 01:24

dereckson accepted this revision.Mar 18 2020, 01:24

This revision is now accepted and ready to land.Mar 18 2020, 01:24

Closed by commit rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final / (authored by dereckson). · Explain WhyMar 18 2020, 02:27

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKOTa2207b3a11f9: Parse correctly https://domain.tld without query or final /.

Revision Contents
Changeset List

			Path	Packages
M			src/HTTP/URL.php (29 lines)
M			tests/HTTP/URLTest.php (10 lines)

Diff 5758

src/HTTP/URL.php

Loading...

tests/HTTP/URLTest.php

Loading...