Use broker factory
ClosedPublic
Actions

Authored by dereckson on Jan 12 2016, 01:35.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF4e32e7178be6: Use broker factory

Summary

Broker service provider change

We move the responsibility to prepare a working broker instance
from the application service provider to the broker library.

D225 has introduced a factory to create an instance of Broker
from a configuration array. We now require keruald/broker 0.3.2+.

The broker factory received the array defined in config/broker.php
as key connections.<correct driver>. The driver is specified at the
driver key from the same file. Each respects 12 factors principle.

Test infrastructure change

We already mock the Blackhole broker in some tests and we will keep
the test code as is, to allow any queer choices like 'integration
test with a working broker' in the future.

For the remaining, regular tests, we want to use everywhere a
blackhole broker and so we update the configuration in BROKER_DRIVER
enviromnet variable.

We add a definition of this blackhole driver to our config.

Test Plan

composer update && phpunit

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

broker

Unit TestsFailed
View All

	Time	Test
	3,578 ms	Jenkins > Nasqueron\Notifications\Tests\Providers\BrokerServiceProviderTest::Unknown Unit Message ("")
	2,104 ms	Unknown Unit Message ("")
	45 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\AMQPActionTest::Unknown Unit Message ("")
	24 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\ActionErrorTest::Unknown Unit Message ("")
	77 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\ActionsReportTest::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 24 Passed)

Event Timeline

dereckson updated this revision to Diff 542.Jan 12 2016, 01:35

dereckson retitled this revision from to Use broker factory.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/20/ (console: https://ci.nasqueron.org/job/test-notifications-phab/20/console)

dereckson planned changes to this revision.Jan 12 2016, 01:36

dereckson added inline comments.

tests/Providers/BrokerServiceProviderTest.php
15	\n at EOF is expected.

EOF

dereckson accepted this revision.Jan 12 2016, 01:37

dereckson edited edge metadata.

dereckson marked an inline comment as done.

This revision is now accepted and ready to land.Jan 12 2016, 01:37

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/20/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/20/console

Build started: https://ci.nasqueron.org/job/test-notifications-phab/21/ (console: https://ci.nasqueron.org/job/test-notifications-phab/21/console)

Build has FAILED

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/21/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/21/console

Currently request a working RabbitMQ server to run tests, we're switching to blackhole.

We already mock the Blackhole broker in some tests and we will keep
the test code as is, to allow any queer choices like 'integration
test with a working broker' in the future.

For the remaining, regular tests, we want to use everywhere a
blackhole broker and so we update the configuration in BROKER_DRIVER
enviromnet variable.

We add a definition of this blackhole driver to our config.

We require keruald/broker 0.3.2+ to get rid of a notice when building
a blackhole broker instance.

This revision is now accepted and ready to land.Jan 12 2016, 02:07

Build started: https://ci.nasqueron.org/job/test-notifications-phab/22/ (console: https://ci.nasqueron.org/job/test-notifications-phab/22/console)