Page MenuHomeDevCentral

Bump phan version
ClosedPublic

Authored by dereckson on Mon, Oct 12, 03:59.

Details

Summary

Bump phan to last version, so we're compatible
with recent AST extension version.

Test Plan

phan

Diff Detail

Repository
rNOTIF Notifications center
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

dereckson created this revision.

How to use Phan?

There is a conflict between Phan and Laravel for a Symfony package, symfony/console, for a refactored Terminal class not used in Laravel.

To fix this, we can:

  • use a legacy phan (but we want to bump to PHP 8 soon)
  • upgrade Laravel to any more recent version, ie 5.4+ (5.4 introduces "symfony/console": "~3.2" which is acceptable)
  • manually fix dependency

Meanwhile, we can't introduce phan in CI.

Manual fix

$ cd vendor/symfony
$ rm -rf console
$ git clone https://github.com/symfony/console.git
$ cd console
$ git checkout v3.2.9

If it's important to be able to run a composer install command, edit vendor/laravel/framework/composer.json to put 3.2 instead of 3.1 there too.

This revision is now accepted and ready to land.Mon, Oct 12, 04:47
This revision was automatically updated to reflect the committed changes.