Bump phan to last version, so we're compatible
with recent AST extension version.
Details
Details
- Reviewers
dereckson - Commits
- rNOTIF7cc1493b431d: Bump phan version
phan
Diff Detail
Diff Detail
- Repository
- rNOTIF Notifications center
- Lint
Lint Passed - Unit
No Test Coverage - Branch
- fix-phan
- Build Status
Buildable 3671 Build 3920: arc lint + arc unit
Event Timeline
Comment Actions
How to use Phan?
There is a conflict between Phan and Laravel for a Symfony package, symfony/console, for a refactored Terminal class not used in Laravel.
To fix this, we can:
- use a legacy phan (but we want to bump to PHP 8 soon)
- upgrade Laravel to any more recent version, ie 5.4+ (5.4 introduces "symfony/console": "~3.2" which is acceptable)
- manually fix dependency
Meanwhile, we can't introduce phan in CI.
Manual fix
$ cd vendor/symfony $ rm -rf console $ git clone https://github.com/symfony/console.git $ cd console $ git checkout v3.2.9
If it's important to be able to run a composer install command, edit vendor/laravel/framework/composer.json to put 3.2 instead of 3.1 there too.