Page MenuHomeDevCentral

Bump phan version
ClosedPublic

Authored by dereckson on Oct 12 2020, 03:59.
Tags
None
Referenced Files
F3765098: D2364.diff
Fri, Nov 22, 10:18
Unknown Object (File)
Mon, Nov 18, 03:41
Unknown Object (File)
Sun, Nov 10, 06:17
Unknown Object (File)
Mon, Nov 4, 08:37
Unknown Object (File)
Wed, Oct 30, 02:47
Unknown Object (File)
Sat, Oct 26, 15:58
Unknown Object (File)
Wed, Oct 23, 12:39
Unknown Object (File)
Oct 16 2024, 20:54
Subscribers
None

Details

Summary

Bump phan to last version, so we're compatible
with recent AST extension version.

Test Plan

phan

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
No Test Coverage
Branch
fix-phan
Build Status
Buildable 3671
Build 3920: arc lint + arc unit

Event Timeline

dereckson created this revision.

How to use Phan?

There is a conflict between Phan and Laravel for a Symfony package, symfony/console, for a refactored Terminal class not used in Laravel.

To fix this, we can:

  • use a legacy phan (but we want to bump to PHP 8 soon)
  • upgrade Laravel to any more recent version, ie 5.4+ (5.4 introduces "symfony/console": "~3.2" which is acceptable)
  • manually fix dependency

Meanwhile, we can't introduce phan in CI.

Manual fix

$ cd vendor/symfony
$ rm -rf console
$ git clone https://github.com/symfony/console.git
$ cd console
$ git checkout v3.2.9

If it's important to be able to run a composer install command, edit vendor/laravel/framework/composer.json to put 3.2 instead of 3.1 there too.

This revision is now accepted and ready to land.Oct 12 2020, 04:47
This revision was automatically updated to reflect the committed changes.