Differential D2396

Reduce definitions of common variables
ClosedPublic
Actions

Authored by dereckson on Aug 29 2021, 12:44.

Details

Reviewers

dereckson

Maniphest Tasks

T1646: Compile darkbot on Eglide

Commits

rDARKBOT3633321609ab: This fixes the following issue:
rDARKBOT9b082e2d649c: This fixes the following issue:

Summary

This fixes the following issue:

/usr/bin/ld: general.o:/opt/darkbot/build/./../source/prototypes.h:132:
multiple definition of `alarmed';
chan.o:/opt/darkbot/build/./../source/prototypes.h:132: first defined here

Ref T1646.

Test Plan

Compile under FreeBSD with LLVM, Cygwin and Debian with gcc

Diff Detail

Repository

rDARKBOT Darkbot

Lint

Lint Passed

Unit

No Test Coverage

Branch

T1646-multiple-definitions

Build Status

Buildable 3718
Build 3968: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Aug 29 2021, 12:44

dereckson created this revision.

Harbormaster completed remote builds in B3718: Diff 6024.Aug 29 2021, 12:44

This revision was not accepted when it landed; it landed in state Needs Review.Aug 29 2021, 12:45

Closed by commit rDARKBOT9b082e2d649c: This fixes the following issue: (authored by dereckson). · Explain Why

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDARKBOT9b082e2d649c: This fixes the following issue:.

dereckson added a commit: rDARKBOT3633321609ab: This fixes the following issue:.Aug 29 2021, 12:48

dereckson reopened this revision.Aug 29 2021, 12:48

dereckson accepted this revision.

This revision is now accepted and ready to land.Aug 29 2021, 12:48

dereckson closed this revision.Aug 29 2021, 12:48

dereckson retitled this revision from This fixes the following issue: to Reduce definitions of common variables.Aug 29 2021, 13:06

dereckson edited the summary of this revision. (Show Details)

Revision Contents
Changeset List

Path

Size

source/

prototypes.h

7 lines

vars.h

5 lines

Diff 6024

View Options

source/prototypes.h