Paths

Table of Contentst

Differential D240

Tests for console commands
ClosedPublic
Actions

Authored by dereckson on Jan 12 2016, 18:26.

Tags

None

Referenced Files

	F5425372: D240.diff
	Mon, Mar 10, 15:25

	F5424950: D240.id.diff
	Mon, Mar 10, 11:46

	Unknown Object (File)
	Sat, Mar 8, 08:34

	Unknown Object (File)
	Thu, Mar 6, 04:39

	Unknown Object (File)
	Wed, Mar 5, 19:00

	Unknown Object (File)
	Sat, Mar 1, 02:02

	Unknown Object (File)
	Tue, Feb 25, 11:58

	Unknown Object (File)
	Sun, Feb 16, 06:47

Subscribers

None

Details

Reviewers

Commits

Unknown Object (Diffusion Commit)
rNOTIFf6c50f85d0c7: Tests for console commands

Summary

The kernel test checks if every command in app/Console/Commands/ is
also declared app/Console/Kernel.php $commands array (or otherwise
added to the console kernel).

The TestCase class provides logic specific to test commands: it
resolves the command and gets a Symfony command tester instance.

We give a sample of how to implement a test class for a command in
InspireTest, which tests the Laravel default command inspire.

Reference: http://symfony.com/doc/current/components/console/introduction.html#testing-commands

Test Plan

Run tests

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Test Failures

Branch

test/ConfigShow

Unit TestsFailed
View All

	Time	Test
	9 ms	Unknown Unit Message ("")
	8,650 ms	Unknown Unit Message ("")
	9,997 ms	Unknown Unit Message ("")
	33 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\AMQPActionTest::Unknown Unit Message ("")
	24 ms	Jenkins > Nasqueron\Notifications\Tests\Actions\ActionErrorTest::Unknown Unit Message ("")
		View Full Test Results (1 Failed · 38 Passed)

Event Timeline

dereckson updated this revision to Diff 564.Jan 12 2016, 18:26

dereckson retitled this revision from to Tests for console commands.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/31/ (console: https://ci.nasqueron.org/job/test-notifications-phab/31/console)

dereckson planned changes to this revision.Jan 12 2016, 18:26

dereckson updated this object.

dereckson removed a subscriber: alken-orin.

dereckson added inline comments.

tests/Console/Commands/TestCase.php
60	Add \n

Build was aborted

Link to build: https://ci.nasqueron.org/job/test-notifications-phab/31/
See console output for more information: https://ci.nasqueron.org/job/test-notifications-phab/31/console

\n

Build started: https://ci.nasqueron.org/job/test-notifications-phab/32/ (console: https://ci.nasqueron.org/job/test-notifications-phab/32/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/32/ for more details.

dereckson planned changes to this revision.Jan 12 2016, 18:37

dereckson added inline comments.

tests/Console/Commands/TestCase.php
10	not used
tests/Console/KernelTest.php
9	Not used

dereckson marked 2 inline comments as done.Jan 12 2016, 18:38

dereckson added inline comments.

tests/Console/Commands/TestCase.php
10	Used: `return self::findInstanceOf($expectedType, Artisan::all());` (line 57)

-use Config;

dereckson accepted this revision.Jan 12 2016, 18:42

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 12 2016, 18:42

Build started: https://ci.nasqueron.org/job/test-notifications-phab/33/ (console: https://ci.nasqueron.org/job/test-notifications-phab/33/console)

Build is green https://ci.nasqueron.org/job/test-notifications-phab/33/ for more details.

Correct branch

Build started: https://ci.nasqueron.org/job/test-notifications-phab/34/ (console: https://ci.nasqueron.org/job/test-notifications-phab/34/console)

Closed by commit rNOTIFf6c50f85d0c7: Tests for console commands (authored by dereckson, committed by dereckson). · Explain WhyJan 12 2016, 18:46

This revision was automatically updated to reflect the committed changes.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/34/ for more details.

Revision Contents
Changeset List

Path

Size

tests/

Console/

Commands/

21 lines

InspireTest.php

18 lines

59 lines

83 lines

Diff 566

tests/Console/Commands/ConfigShow.php

Loading...

tests/Console/Commands/InspireTest.php

Loading...

tests/Console/Commands/TestCase.php

Loading...

tests/Console/KernelTest.php

Loading...