Differential D242

Fix AMQPBroker configuration overwrite issue
ClosedPublic
Actions

Authored by dereckson on Jan 14 2016, 14:27.

Details

Reviewers

dereckson

Commits

rKBROKER6709628d4a2e: Fix AMQPBroker configuration overwrite issue

Summary

The parameters provided to AMQPBroker::makeFromConfig
were overwritten by the default configuration.

Test Plan

Send a payload to the Notification Center,
which uses this method.

Diff Detail

Repository

rKBROKER Keruald Broker

Lint

Lint Passed

Unit

Tests Passed

Branch

master

Build Status

Buildable 307
Build 339: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 570.Jan 14 2016, 14:27

dereckson retitled this revision from to Fix AMQPBroker configuration overwrite issue.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

dereckson accepted this revision.Jan 14 2016, 14:28

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 14 2016, 14:28

Closed by commit rKBROKER6709628d4a2e: Fix AMQPBroker configuration overwrite issue (authored by dereckson, committed by dereckson). · Explain WhyJan 14 2016, 14:28

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D244: Bump keruald/broker required version to 0.3.3.Jan 14 2016, 14:42

dereckson mentioned this in rNOTIF3de9024d42b5: Bump keruald/broker required version to 0.3.3.Jan 14 2016, 19:54

dereckson mentioned this in rNOTIF72793ebb7c94: Bump keruald/broker required version to 0.3.3.Jan 14 2016, 20:07

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

src/

AMQPBroker.php

3 lines

64%

Diff 570

View Options

Fix AMQPBroker configuration overwrite issueClosedPublicActions