Page MenuHomeDevCentral
Differential D2486

Avoid to compare shell_exec() result as false or null
ClosedPublic
Actions

Authored by dereckson on Jan 26 2022, 19:41.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 31, 19:45
Unknown Object (File)
Tue, Jul 29, 09:30
Unknown Object (File)
Mon, Jul 28, 11:40
Unknown Object (File)
Sun, Jul 27, 16:12
Unknown Object (File)
Sat, Jul 26, 11:15
Unknown Object (File)
Tue, Jul 22, 01:24
Unknown Object (File)
Sun, Jul 20, 04:35
Unknown Object (File)
Sat, Jul 19, 20:59
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rKOTaba618f720af: Avoid to compare shell_exec() result as false or null
Summary

When comparing the command output with a string,
shell_exec() can returns false or null.

If it returns null, trim will receives NULL value,
and that's behavior is deprecated under PHP 7.4+:

trim(null) would return:

Deprecated: trim(): Passing null to parameter #1 ($string)
of type string is deprecated

Diff Detail

Repository
rKOT Keruald OmniTools
Lint
Lint Skipped
Unit
Tests Skipped
Branch
shell_exec_can_return_false_or_null
Build Status
Buildable 3875
Build 4126: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Jan 26 2022, 19:41
dereckson created this revision.
Harbormaster completed remote builds in B3875: Diff 6266.Jan 26 2022, 19:41
dereckson accepted this revision.Jan 26 2022, 19:42
This revision is now accepted and ready to land.Jan 26 2022, 19:42
Closed by commit rKOTaba618f720af: Avoid to compare shell_exec() result as false or null (authored by dereckson). · Explain WhyJan 26 2022, 19:43
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rKOTaba618f720af: Avoid to compare shell_exec() result as false or null.

Revision Contents
Changeset List

PathSize
src/
OS/
2 lines

Diff 6266

View Options

src/OS/CurrentProcess.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator