Differential D250

Removed extraneous return after exception thrown
ClosedPublic
Actions

Authored by dereckson on Jan 21 2016, 02:09.

Details

Reviewers

dereckson

Commits

Unknown Object (Diffusion Commit)
rNOTIF9d9167a151ca: Removed extraneous return after exception thrown

Test Plan

trivial

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

No Test Coverage

Branch

extraneous-return

Event Timeline

dereckson updated this revision to Diff 585.Jan 21 2016, 02:09

dereckson retitled this revision from to Removed extraneous return after exception thrown.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson added a reviewer: dereckson.

Build started: https://ci.nasqueron.org/job/test-notifications-phab/41/ (console: https://ci.nasqueron.org/job/test-notifications-phab/41/console)

dereckson accepted this revision.Jan 21 2016, 02:10

dereckson edited edge metadata.

This revision is now accepted and ready to land.Jan 21 2016, 02:10

Closed by commit rNOTIF9d9167a151ca: Removed extraneous return after exception thrown (authored by dereckson, committed by dereckson). · Explain WhyJan 21 2016, 02:10

This revision was automatically updated to reflect the committed changes.

dereckson mentioned this in D249: Integration test: 404 for not existing Phabricator door.Jan 21 2016, 02:11

Build is green https://ci.nasqueron.org/job/test-notifications-phab/41/ for more details.

Revision Contents
Changeset List

Path

Size

app/

Http/

Controllers/

Gate/

PhabricatorGateController.php

2 lines

Diff 585

View Options

app/Http/Controllers/Gate/PhabricatorGateController.php

Removed extraneous return after exception thrownClosedPublicActions