Page MenuHomeDevCentral
Differential D2568

Compute CIDR prefix from netmask for RHEL network scripts
ClosedPublic
Actions

Authored by dereckson on Mar 5 2022, 10:56.
Tags
None
Referenced Files
F3618378: D2568.diff
Thu, Oct 3, 04:27
F3617707: D2568.id6487.diff
Thu, Oct 3, 00:37
F3615194: D2568.diff
Wed, Oct 2, 12:47
Unknown Object (File)
Sun, Sep 29, 07:31
Unknown Object (File)
Mon, Sep 23, 01:53
Unknown Object (File)
Wed, Sep 18, 15:44
Unknown Object (File)
Sat, Sep 14, 12:08
Unknown Object (File)
Sat, Sep 14, 12:08
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts
Summary

The network scripts use a CIDR notation like PREFIX=24
instead of a netmask notation.

Salt offers a cidr_to_ipv4_netmask but not the other way
around, so a new network execution module is offered.

This is a follow-up for f9dbdab3b579.

Test Plan

Unit tests are provided for network module

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Mar 5 2022, 10:56
dereckson created this revision.
Harbormaster completed remote builds in B4022: Diff 6486.Mar 5 2022, 10:56
dereckson updated this revision to Diff 6487.Mar 5 2022, 11:00

Remove fix to Rust tests from this change

Harbormaster completed remote builds in B4023: Diff 6487.Mar 5 2022, 11:00
dereckson updated this revision to Diff 6488.Mar 5 2022, 11:42

Allow to detect netmask in the configuration is invalid

Harbormaster completed remote builds in B4024: Diff 6488.Mar 5 2022, 11:42
dereckson added a comment.Mar 7 2022, 19:12

network is already the name of an execution module:
https://docs.saltproject.io/en/latest/ref/modules/all/salt.modules.network.html

Probably cool to rename it, even if Salt is happy to let us replace modules like that.

dereckson updated this revision to Diff 6500.Mar 7 2022, 19:14

Allow lambda expression

Harbormaster completed remote builds in B4031: Diff 6500.Mar 7 2022, 19:14
dereckson updated this revision to Diff 6501.Mar 7 2022, 19:27

Avoid to shadow network execution module

Harbormaster completed remote builds in B4032: Diff 6501.Mar 7 2022, 19:27
dereckson updated this revision to Diff 6502.Mar 7 2022, 19:30

Rename too in state

Harbormaster completed remote builds in B4033: Diff 6502.Mar 7 2022, 19:30
dereckson accepted this revision.Mar 7 2022, 19:31
This revision is now accepted and ready to land.Mar 7 2022, 19:31
Closed by commit rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts (authored by dereckson). · Explain WhyMar 7 2022, 19:31
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPS0f572c4f7518: Compute CIDR prefix from netmask for RHEL network scripts.

Revision Contents
Changeset List

PathSize
1 line
4 lines
_modules/
46 lines
_tests/
modules/
52 lines
1 line
roles/
core/
network/
files/
RedHat/
2 lines
1 line

Diff 6503

View Options

.arclint

Loading...
View Options

.flake8

Loading...
View Options

_modules/network_utils.py

Loading...
View Options

_tests/modules/test_network.py

Loading...
View Options

requirements.txt

Loading...
View Options

roles/core/network/files/RedHat/ifcfg-private

Loading...
View Options

roles/core/network/private.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator