Page MenuHomeDevCentral

Configure Flake8 linter for Arcanist
ClosedPublic

Authored by dereckson on Feb 14 2023, 19:19.
Tags
None
Referenced Files
F9785678: D2795.id7093.diff
Fri, Jun 13, 18:26
F9785122: D2795.id7094.diff
Fri, Jun 13, 18:18
Unknown Object (File)
Sat, May 31, 19:20
Unknown Object (File)
Wed, May 28, 14:40
Unknown Object (File)
Tue, May 20, 01:18
Unknown Object (File)
Mon, May 19, 23:24
Unknown Object (File)
Mon, May 19, 20:33
Unknown Object (File)
Mon, May 19, 08:54
Subscribers
None

Details

Summary

Allow to specify pillar and other Salt dictionaries as builtins,
so flake8 won't complain anymore those names don't exist.

Lint also the .sls #!py files, as they are written in Python too.

This currently needs to use Nasqueron version of arcanist, production branch:
https://github.com/nasqueron/arcanist/commit/15aa482eacd90fdbd238bc8b7a17c4bbba8a0bdd

Test Plan

arc lint

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
main
Build Status
Buildable 4427
Build 4694: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Feb 14 2023, 19:20
This revision was automatically updated to reflect the committed changes.