Page MenuHomeDevCentral

Configure Flake8 linter for Arcanist
ClosedPublic

Authored by dereckson on Feb 14 2023, 19:19.
Tags
None
Referenced Files
F56986907: D2795.id7093.diff
Thu, Nov 12, 12:20
F56981500: D2795.id7094.diff
Thu, Nov 12, 09:11
F56742229: D2795.id7094.diff
Sun, Nov 8, 21:11
F56540896: D2795.id7093.diff
Fri, Nov 6, 23:44
F56066458: D2795.id.diff
Mon, Nov 2, 12:51
Unknown Object (File)
Fri, Oct 30, 16:33
Unknown Object (File)
Tue, Oct 27, 11:32
Unknown Object (File)
Sun, Oct 25, 12:59
Subscribers
None

Details

Summary

Allow to specify pillar and other Salt dictionaries as builtins,
so flake8 won't complain anymore those names don't exist.

Lint also the .sls #!py files, as they are written in Python too.

This currently needs to use Nasqueron version of arcanist, production branch:
https://github.com/nasqueron/arcanist/commit/15aa482eacd90fdbd238bc8b7a17c4bbba8a0bdd

Test Plan

arc lint

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Passed
Unit
No Test Coverage
Branch
main
Build Status
Buildable 4427
Build 4694: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Feb 14 2023, 19:20
This revision was automatically updated to reflect the committed changes.