Page MenuHomeDevCentral
Differential D2842

Avoid duplicate proxy_redirect nginx directive
ClosedPublic
Actions

Authored by DorianWinty on Mar 5 2023, 18:37.
Tags
None
Referenced Files
F2846701: D2842.id.diff
Wed, Apr 24, 10:35
F2846426: D2842.id7249.diff
Wed, Apr 24, 08:54
F2846425: D2842.id7245.diff
Wed, Apr 24, 08:54
Unknown Object (File)
Mon, Apr 22, 21:40
Unknown Object (File)
Mon, Apr 22, 19:56
Unknown Object (File)
Mon, Apr 22, 17:17
Unknown Object (File)
Sat, Apr 20, 10:00
Unknown Object (File)
Fri, Apr 19, 01:44
View All Files
Subscribers
None

Details

Reviewers
dereckson
Commits
rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive
Summary

Previously, nginx accepted two values for proxy_redirect.

In more recent version, this is a fatal error.

Move the directive into each location proxy block.

Test Plan

Tested on Dwellers.

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

DorianWinty requested review of this revision.Mar 5 2023, 18:37
DorianWinty created this revision.
DorianWinty edited the test plan for this revision. (Show Details)Mar 5 2023, 18:53
dereckson accepted this revision.Mar 5 2023, 18:54
dereckson retitled this revision from Avoid duplicate proxy_redirect off to Avoid duplicate proxy_redirect nginx directive.
dereckson edited the summary of this revision. (Show Details)
dereckson edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Mar 5 2023, 18:56
Harbormaster completed remote builds in B4490: Diff 7245.Mar 5 2023, 20:36
Closed by commit rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive (authored by DorianWinty). · Explain WhyMar 5 2023, 20:36
This revision was automatically updated to reflect the committed changes.
DorianWinty added a commit: rOPS76a2ce59699e: Avoid duplicate proxy_redirect nginx directive.

Revision Contents
Changeset List

PathSize
roles/
paas-docker/
nginx/
files/
includes/
2 lines
vhosts/
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
1 line
3 lines
1 line
1 line
1 line
1 line

Diff 7249

View Options

roles/paas-docker/nginx/files/includes/proxy_params

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/_default.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/acme_dns.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/auth-grove.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/bugzilla.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/cachet.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/etherpad.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/hauk.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/jenkins.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/openfire.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/phabricator.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/pixelfed.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/rabbitmq.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/sentry.conf

Loading...
View Options

roles/paas-docker/nginx/files/vhosts/tommy.conf

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator