Page MenuHomeDevCentral
Differential D286

ProjectGroupMapping renamed back to PhabricatorGroupMapping
ClosedPublic
Actions

Authored by dereckson on Feb 18 2016, 06:31.
Tags
None
Referenced Files
F3772030: D286.diff
Sun, Nov 24, 02:30
F3770539: D286.id.diff
Sat, Nov 23, 20:43
F3768890: D286.diff
Sat, Nov 23, 11:15
Unknown Object (File)
Thu, Nov 21, 12:05
Unknown Object (File)
Thu, Nov 21, 12:05
Unknown Object (File)
Sun, Nov 17, 22:10
Unknown Object (File)
Wed, Nov 13, 19:12
Unknown Object (File)
Wed, Nov 13, 08:54
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIFe7119bacc9c6: ProjectGroupMapping renamed back to PhabricatorGroupMapping
Summary

The mappings are actually {projects, keywords} → groups.

This is a partal revert of 77b457cdb9f630ae7479806471fcff7eacb0f4f6.

Test Plan

Run tests

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
PhabricatorGroupMapping

Event Timeline

dereckson updated this revision to Diff 674.Feb 18 2016, 06:31
dereckson retitled this revision from to ProjectGroupMapping renamed back to PhabricatorGroupMapping.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Feb 18 2016, 06:34

Build started: https://ci.nasqueron.org/job/test-notifications-phab/82/ (console: https://ci.nasqueron.org/job/test-notifications-phab/82/console)

alken-orin added a comment.Feb 18 2016, 06:41

Build is green https://ci.nasqueron.org/job/test-notifications-phab/82/ for more details.

dereckson accepted this revision.Feb 18 2016, 06:42
dereckson edited edge metadata.
This revision is now accepted and ready to land.Feb 18 2016, 06:42
Closed by commit rNOTIFe7119bacc9c6: ProjectGroupMapping renamed back to PhabricatorGroupMapping (authored by dereckson, committed by dereckson). · Explain WhyFeb 18 2016, 06:42
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Analyzers/
Phabricator/
PhabricatorGroupMapping.php
ProjectGroupMapping.php
2 lines100%
Loading...
2 lines--
--
tests/
Analyzers/
Phabricator/
PhabricatorGroupMappingTest.php
ProjetGroupMappingTest.php
16 lines--
--

Diff 674

View Options

app/Analyzers/Phabricator/PhabricatorGroupMapping.php

Loading...
View Options

app/Analyzers/Phabricator/PhabricatorPayloadAnalyzerConfiguration.php

Loading...
View Options

app/Analyzers/Phabricator/ProjectGroupMapping.php

Loading...
View Options

tests/Analyzers/Phabricator/PhabricatorGroupMappingTest.php

Loading...
View Options

tests/Analyzers/Phabricator/ProjetGroupMappingTest.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator