Page MenuHomeDevCentral
Differential D2913

Align GateController::getServiceName visibility
ClosedPublic
Actions

Authored by dereckson on Mar 25 2023, 12:48.
Tags
None
Referenced Files
F24398336: D2913.diff
Wed, Feb 18, 21:15
F24398139: D2913.diff
Wed, Feb 18, 20:52
Unknown Object (File)
Sun, Feb 15, 23:33
Unknown Object (File)
Wed, Feb 11, 11:40
Unknown Object (File)
Wed, Feb 11, 05:38
Unknown Object (File)
Wed, Feb 11, 03:58
Unknown Object (File)
Wed, Feb 11, 01:02
Unknown Object (File)
Tue, Feb 3, 00:26
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1804: Align access levels for GateController::getServiceName()
Commits
rNOTIFc3a6214efbc5: Align GateController::getServiceName visibility
Summary

This is a follow-up for 57e8fae268ce and bff16342f354.

Fixes T1804.

Test Plan

ant

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.Mar 25 2023, 12:48
dereckson published this revision for review.Mar 25 2023, 12:48
dereckson accepted this revision.
This revision is now accepted and ready to land.Mar 25 2023, 12:49
This revision was landed with ongoing or failed builds.Mar 25 2023, 12:49
Closed by commit rNOTIFc3a6214efbc5: Align GateController::getServiceName visibility (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rNOTIFc3a6214efbc5: Align GateController::getServiceName visibility.

Revision Contents
Changeset List

PathSize
app/
Http/
Controllers/
Gate/
2 lines

Diff 7424

View Options

app/Http/Controllers/Gate/NotificationGateController.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator