Paths

Table of Contentst

Propagate errors if we can't handle it in vault_get
ClosedPublic
Actions

Authored by dereckson on Apr 12 2023, 00:01.

Tags

None

Referenced Files

	F3929258: D3003.id.diff
	Sun, Dec 22, 08:26

	Unknown Object (File)
	Fri, Dec 13, 00:43

	Unknown Object (File)
	Fri, Dec 13, 00:43

	Unknown Object (File)
	Fri, Dec 13, 00:24

	Unknown Object (File)
	Fri, Dec 13, 00:24

	Unknown Object (File)
	Sat, Dec 7, 08:51

	Unknown Object (File)
	Mon, Dec 2, 20:29

	Unknown Object (File)
	Wed, Nov 27, 00:10

View All Files

Subscribers

None

Details

Reviewers

dereckson

Commits

rVIPERb67b47057a1a: Propagate errors if we can't handle it in vault_get

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository

rVIPER ViperServ scripts

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 12 2023, 00:01

dereckson created this revision.

Harbormaster completed remote builds in B4749: Diff 7668.Apr 12 2023, 00:01

dereckson accepted this revision.Apr 12 2023, 00:09

This revision is now accepted and ready to land.Apr 12 2023, 00:09

Closed by commit rVIPERb67b47057a1a: Propagate errors if we can't handle it in vault_get (authored by dereckson). · Explain WhyApr 12 2023, 00:09

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rVIPERb67b47057a1a: Propagate errors if we can't handle it in vault_get.

Revision Contents
Changeset List

Path

Size

Vault.tcl

3 lines

Diff 7669

View Options

Propagate errors if we can't handle it in vault_getClosedPublicActions