Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 31, 12:34
Unknown Object (File)
Thu, Oct 17, 19:23
Unknown Object (File)
Mon, Oct 14, 06:47
Unknown Object (File)
Sun, Oct 13, 04:19
Unknown Object (File)
Sun, Oct 6, 19:25
Unknown Object (File)
Sun, Oct 6, 19:24
Unknown Object (File)
Sun, Oct 6, 17:08
Unknown Object (File)
Oct 4 2024, 15:53
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09