Page MenuHomeDevCentral

Propagate errors if we can't handle it in vault_get
ClosedPublic

Authored by dereckson on Apr 12 2023, 00:01.
Tags
None
Referenced Files
F24122652: D3003.diff
Tue, Feb 10, 08:11
F24096900: D3003.id7668.diff
Mon, Feb 9, 17:11
Unknown Object (File)
Mon, Feb 9, 01:33
Unknown Object (File)
Fri, Feb 6, 09:40
Unknown Object (File)
Tue, Feb 3, 17:08
Unknown Object (File)
Mon, Feb 2, 10:44
Unknown Object (File)
Sat, Jan 31, 15:24
Unknown Object (File)
Mon, Jan 26, 21:22
Subscribers
None

Details

Summary

When an error is caught in vault_get, it only handles the 403 case.

If vault is currently in 503 (still sealed for example), it does nothing,
so the return fails with can't read "credential": no such variable.

This change allows vault_get to propagate instead the error:
"Vault returned HTTP/1.1 503 Service Unavailable, 200 OK was expected."

Test Plan

Tested on Wearg

Diff Detail

Repository
rVIPER ViperServ scripts
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
vault-unsealed
Build Status
Buildable 4749
Build 5030: arc lint + arc unit

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.Apr 12 2023, 00:09