Page MenuHomeDevCentral
Differential D3005

Reduce the length of GRE interface name
ClosedPublic
Actions

Authored by dereckson on Apr 12 2023, 23:33.
Tags
None
Referenced Files
F3764639: D3005.diff
Fri, Nov 22, 07:10
Unknown Object (File)
Sun, Nov 17, 18:15
Unknown Object (File)
Fri, Nov 15, 19:54
Unknown Object (File)
Wed, Nov 13, 04:49
Unknown Object (File)
Mon, Nov 11, 23:45
Unknown Object (File)
Sun, Nov 10, 21:47
Unknown Object (File)
Sun, Nov 10, 18:04
Unknown Object (File)
Wed, Nov 6, 15:25
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T1832: Fix core role for Debian nodes
Commits
rOPSaa208267aeb6: Reduce the length of GRE interface name
Summary

The define IFNAMSIZ in Linux kernel defines the maximum length of an interface
name. By default, 16 characters, including the final '\0'.

As such, names like gre-drake_via_router-001 are too long.

gre-drake seems to be descriptive enough, as a node has only one GRE tunnel
if it's not our router.

Reference: include/uapi/linux/if.h

Ref T1832

Test Plan

Deploy on cloudhugger, ifconfig gre-drake

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson requested review of this revision.Apr 12 2023, 23:33
dereckson created this revision.
Harbormaster completed remote builds in B4752: Diff 7673.Apr 12 2023, 23:33
dereckson added a comment.EditedApr 12 2023, 23:34

Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/uapi/linux/if.h

if.h
#if __UAPI_DEF_IF_IFNAMSIZ
#define	IFNAMSIZ	16
#endif /* __UAPI_DEF_IF_IFNAMSIZ */
#define	IFALIASZ	256
#define	ALTIFNAMSIZ	128
#include <linux/hdlc/ioctl.h>
dereckson accepted this revision.Apr 12 2023, 23:34
This revision is now accepted and ready to land.Apr 12 2023, 23:34
This revision was landed with ongoing or failed builds.Apr 12 2023, 23:35
Closed by commit rOPSaa208267aeb6: Reduce the length of GRE interface name (authored by dereckson). · Explain Why
This revision was automatically updated to reflect the committed changes.
dereckson added a commit: rOPSaa208267aeb6: Reduce the length of GRE interface name.
dereckson added a reverting change: D3063: Restore GRE tunnels rc names.Apr 27 2023, 22:41
dereckson added a reverting change: rOPS690b374144d7: Restore GRE tunnels rc names.Apr 27 2023, 22:42

Revision Contents
Changeset List

PathSize
_modules/
2 lines
roles/
core/
network/
4 lines

Diff 7674

View Options

_modules/node.py

Loading...
View Options

roles/core/network/gre.sls

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator