Page MenuHomeDevCentral

Refactoring: Service::getInstanceName()
ClosedPublic

Authored by dereckson on Feb 23 2016, 19:22.
Tags
None
Referenced Files
F23809162: D302.id.diff
Fri, Feb 6, 22:34
F23808276: D302.id709.diff
Fri, Feb 6, 22:26
Unknown Object (File)
Thu, Feb 5, 19:26
Unknown Object (File)
Sun, Feb 1, 07:28
Unknown Object (File)
Fri, Jan 30, 09:58
Unknown Object (File)
Thu, Jan 29, 13:08
Unknown Object (File)
Thu, Jan 29, 06:46
Unknown Object (File)
Tue, Jan 27, 19:51
Subscribers

Details

Summary

The config:show command would like a string to represent the instance
in an array. We transfer the responsability to provide this string to
the Service class.

Test Plan
  • A new test is provided to test the method in the two cases
  • php artisan config:show

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
service-getInstanceName

Event Timeline

dereckson retitled this revision from to Refactoring: Service::getInstanceName().
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson edited edge metadata.
This revision is now accepted and ready to land.Feb 23 2016, 20:25
This revision was automatically updated to reflect the committed changes.