Page MenuHomeDevCentral
Differential D309

Le Soir update
ClosedPublic
Actions

Authored by dereckson on Feb 29 2016, 04:42.
Tags
None
Referenced Files
F3764956: D309.diff
Fri, Nov 22, 09:30
Unknown Object (File)
Thu, Nov 21, 09:29
Unknown Object (File)
Thu, Nov 21, 09:29
Unknown Object (File)
Thu, Nov 21, 09:28
Unknown Object (File)
Thu, Nov 21, 09:28
Unknown Object (File)
Thu, Nov 21, 09:28
Unknown Object (File)
Thu, Nov 21, 09:28
Unknown Object (File)
Thu, Nov 21, 08:34
View All Files
Subscribers
None

Details

Reviewers
dereckson
Maniphest Tasks
T697: Le Soir - Redirection limit reached
Commits
rSTGfaa24e691131: Le Soir update
Summary

Le Soir now has three formats:

  • the regular site
  • the archives site archives.lesoir.be
  • new archives on www.lesoir.be/archives

This change provides analysis code for the third, and refactors
the LeSoirPage and ArchivesLeSoirPage classes.

It also improves date handling.

Test Plan

The three URL covers the three cases:

Diff Detail

Repository
rSTG Source templates generator
Lint
No Lint Coverage
Unit
No Test Coverage
Branch
lesoir
Build Status
Buildable 401
Build 482: arc lint + arc unit

Event Timeline

dereckson updated this revision to Diff 723.Feb 29 2016, 04:42
dereckson retitled this revision from to Le Soir update.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson set the repository for this revision to rSTG Source templates generator.
dereckson updated this object.
dereckson planned changes to this revision.Feb 29 2016, 04:44
dereckson added inline comments.
page.php
127

This method is for D308 actually.

pages/lesoir.php
95

Move this part to a getTitleForArchive method.

dereckson marked an inline comment as done.Feb 29 2016, 05:02
dereckson added inline comments.
page.php
127

Er, D307.

pages/archiveslesoir.php
3

To move to D308.

dereckson edited edge metadata.Feb 29 2016, 05:03
dereckson marked 3 inline comments as done.
dereckson updated this revision to Diff 726.Feb 29 2016, 05:05
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson edited edge metadata.

Rebase against D307 and D308.

dereckson updated this revision to Diff 727.EditedFeb 29 2016, 05:07

Select only one commit

dereckson planned changes to this revision.Feb 29 2016, 05:09

New method LeSoirPage::getTitleForArchive.

dereckson updated this revision to Diff 728.Feb 29 2016, 05:13

LeSoirPage::getTitleForArchive

dereckson added a parent revision: D308: Autoloader to handle Pages/ content.Feb 29 2016, 05:14
dereckson updated this revision to Diff 787.Mar 7 2016, 22:17
dereckson marked an inline comment as done.

Rebased.

dereckson accepted this revision.Mar 7 2016, 22:18
dereckson edited edge metadata.
This revision is now accepted and ready to land.Mar 7 2016, 22:18
Closed by commit rSTGfaa24e691131: Le Soir update (authored by dereckson, committed by dereckson). · Explain WhyMar 7 2016, 22:18
This revision was automatically updated to reflect the committed changes.
dereckson added a task: T697: Le Soir - Redirection limit reached.Mar 7 2016, 22:44

Revision Contents
Changeset List

PathSize
23 lines
pages/
19 lines
54 lines

Diff 728

View Options

page.php

Loading...
View Options

pages/archiveslesoir.php

Loading...
View Options

pages/lesoir.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator