Page MenuHomeDevCentral

Don't escape new line in Etherpad welcome message
ClosedPublic

Authored by dereckson on May 18 2023, 11:31.
Tags
None
Referenced Files
F3763571: D3106.id7926.diff
Fri, Nov 22, 00:34
Unknown Object (File)
Mon, Nov 18, 04:49
Unknown Object (File)
Tue, Nov 12, 06:35
Unknown Object (File)
Sat, Nov 2, 16:37
Unknown Object (File)
Thu, Oct 31, 07:28
Unknown Object (File)
Oct 20 2024, 22:51
Unknown Object (File)
Oct 17 2024, 16:06
Unknown Object (File)
Oct 17 2024, 15:37
Subscribers
None

Details

Summary

Both the json (Salt) and tojson (Jinja2) filters escape new lines
as \\n in JSON strings.

In this specific case, we need a direct \n, as we output configuration
and not a string template to be rendered aftewards.

This new line escape dance is a little bit hacky, but it's not straightforward
to determine what kind of JSON it needs to produce, to create a new filter.

This is a follow-up for dda0e01728ce.

Ref T1871.

Test Plan

Restarted Etherpad, created new pad, new lines are OK

Diff Detail

Repository
rOPS Nasqueron Operations
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dereckson created this revision.
This revision is now accepted and ready to land.May 18 2023, 11:32