Page MenuHomeDevCentral
Differential D317

Service providers for PhabricatorAPI and ProjectsMap
ClosedPublic
Actions

Authored by dereckson on Mar 3 2016, 02:55.
Tags
None
Referenced Files
F3920347: D317.diff
Fri, Dec 20, 14:30
Unknown Object (File)
Fri, Dec 13, 14:46
Unknown Object (File)
Wed, Dec 11, 19:54
Unknown Object (File)
Wed, Dec 11, 07:18
Unknown Object (File)
Wed, Dec 11, 07:00
Unknown Object (File)
Mon, Dec 9, 11:28
Unknown Object (File)
Mon, Dec 2, 12:15
Unknown Object (File)
Sun, Dec 1, 13:49
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIF6ea3b6b96219: Service providers for PhabricatorAPI and ProjectsMap
Summary

Dependency injection for PhabricatorAPI and ProjectsMap classes.

This allows to provide tests for Phabricator related functions.

Test Plan

Unit tests cover the factory methods.

D241 code tested against this revision.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
PhabricatorFactory

Event Timeline

dereckson updated this revision to Diff 748.Mar 3 2016, 02:55
dereckson retitled this revision from to Service providers for PhabricatorAPI and ProjectsMap.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
dereckson set the repository for this revision to rNOTIF Notifications center.
alken-orin added a subscriber: alken-orin.Mar 3 2016, 02:57

Build started: https://ci.nasqueron.org/job/test-notifications-phab/101/ (console: https://ci.nasqueron.org/job/test-notifications-phab/101/console)

dereckson added a child revision: D241: Tests for config:show console command.Mar 3 2016, 02:57
alken-orin added a comment.Mar 3 2016, 03:08

Build is green https://ci.nasqueron.org/job/test-notifications-phab/101/ for more details.

dereckson updated this revision to Diff 749.Mar 3 2016, 04:22
dereckson edited edge metadata.

More tests, more facade

alken-orin added a comment.Mar 3 2016, 04:22

Build started: https://ci.nasqueron.org/job/test-notifications-phab/102/ (console: https://ci.nasqueron.org/job/test-notifications-phab/102/console)

alken-orin added a comment.Mar 3 2016, 04:35

Build is green https://ci.nasqueron.org/job/test-notifications-phab/102/ for more details.

dereckson planned changes to this revision.Mar 3 2016, 04:40

ProjectsMap Facade isn't covered by tests.

dereckson updated this revision to Diff 750.Mar 3 2016, 04:45
dereckson edited edge metadata.

Test facades

alken-orin added a comment.Mar 3 2016, 04:46

Build started: https://ci.nasqueron.org/job/test-notifications-phab/103/ (console: https://ci.nasqueron.org/job/test-notifications-phab/103/console)

alken-orin added a comment.Mar 3 2016, 04:56

Build is green https://ci.nasqueron.org/job/test-notifications-phab/103/ for more details.

dereckson accepted this revision.Mar 3 2016, 10:57
dereckson edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 10:57
Closed by commit rNOTIF6ea3b6b96219: Service providers for PhabricatorAPI and ProjectsMap (authored by dereckson, committed by dereckson). · Explain WhyMar 3 2016, 10:59
This revision was automatically updated to reflect the committed changes.
dereckson mentioned this in D241: Tests for config:show console command.Mar 3 2016, 11:04

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Facades/
21 lines--
Phabricator/
26 lines100%
Loading...
196 lines--
27 lines100%
Loading...
Providers/
30 lines100%
Loading...
30 lines100%
Loading...
config/
3 lines--
tests/
Phabricator/
32 lines--
54 lines--
Providers/
14 lines--
14 lines--
data/
61 lines--

Diff 748

View Options

app/Facades/PhabricatorAPI.php

Loading...
View Options

app/Phabricator/PhabricatorAPIFactory.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
View Options

app/Phabricator/ProjectsMapFactory.php

Loading...
View Options

app/Providers/PhabricatorAPIServiceProvider.php

Loading...
View Options

app/Providers/PhabricatorProjectsMapServiceProvider.php

Loading...
View Options

config/app.php

Loading...
View Options

tests/Phabricator/PhabricatorAPIFactoryTest.php

Loading...
View Options

tests/Phabricator/ProjectsMapFactoryTest.php

Loading...
View Options

tests/Providers/PhabricatorAPIServiceProviderTest.php

Loading...
View Options

tests/Providers/PhabricatorProjectsMapServiceProviderTest.php

Loading...
View Options

tests/data/PhabricatorProjetsQueryReply.json

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator