Differential D3197

Allow to get first item of a collection
ClosedPublic
Actions

Authored by dereckson on Jun 14 2023, 21:08.

Tags

None

Referenced Files

	F8887147: D3197.id8156.diff
	Wed, May 21, 11:20

	F8870418: D3197.id8158.diff
	Wed, May 21, 03:57

	F8837360: D3197.id8158.diff
	Tue, May 20, 17:16

	Unknown Object (File)
	Tue, May 20, 10:57

	Unknown Object (File)
	Mon, May 19, 10:32

	Unknown Object (File)
	Sun, May 18, 06:20

	Unknown Object (File)
	Thu, May 15, 15:00

	Unknown Object (File)
	Thu, May 15, 09:35

Subscribers

None

Details

Reviewers

Commits

rKOT90c2f61aa6f0: Allow to get first item of a collection
rKOTf944b6a22479: Allow to get first item of a collection
rKERUALDb44478a93ce3: Allow to get first item of a collection

Summary

This changes add to BaseCollection classes the following methods:

first() will return the first item if it exists
firstOr() will return the first item if it exists, or a default value if not.

Both are implemented by the WithCollection trait.

Test Plan

Tested in Zed

Diff Detail

Repository

rKERUALD Keruald libraries development repository

Lint

Lint Passed

Unit

Test Failures

Branch

collection-first

Build Status

Buildable 5032
Build 5313: arc lint + arc unit

Unit TestsBroken
View All

	Time	Test
	0 ms	/Users/ssantoro/dev/nasqueron/keruald/keruald/omnitools/tests/Collections/BitsVectorTest.php sh: phpunit: command not found
	0 ms	/Users/ssantoro/dev/nasqueron/keruald/keruald/omnitools/tests/Collections/HashMapTest.php sh: phpunit: command not found
	0 ms	/Users/ssantoro/dev/nasqueron/keruald/keruald/omnitools/tests/Collections/VectorTest.php sh: phpunit: command not found

Event Timeline

dereckson requested review of this revision.Jun 14 2023, 21:08

dereckson created this revision.

Harbormaster completed remote builds in B5032: Diff 8156.Jun 14 2023, 21:08

+tests

Harbormaster completed remote builds in B5033: Diff 8157.Jun 14 2023, 21:14

dereckson accepted this revision.Jun 14 2023, 21:15

dereckson retitled this revision from Allow to get first items of a collection to Allow to get first item of a collection.

dereckson edited the summary of this revision. (Show Details)

This revision is now accepted and ready to land.Jun 14 2023, 21:16

Closed by commit rKERUALDb44478a93ce3: Allow to get first item of a collection (authored by dereckson). · Explain WhyJun 14 2023, 21:16

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rKERUALDb44478a93ce3: Allow to get first item of a collection.

dereckson added a commit: rKOTf944b6a22479: Allow to get first item of a collection.Jun 19 2023, 23:14

dereckson added a commit: rKOT90c2f61aa6f0: Allow to get first item of a collection.Jun 19 2023, 23:27

Revision Contents
Changeset List

Path

Size

omnitools/

src/

Collections/

BaseCollection.php

2 lines

WithCollection.php

27 lines

tests/

Collections/

BitsVectorTest.php

32 lines

HashMapTest.php

30 lines

26 lines

Diff 8156

omnitools/src/Collections/BaseCollection.php

Loading...

omnitools/src/Collections/WithCollection.php

Loading...

omnitools/tests/Collections/BitsVectorTest.php

Loading...

omnitools/tests/Collections/HashMapTest.php

Loading...

omnitools/tests/Collections/VectorTest.php

Loading...