Page MenuHomeDevCentral

Add basic navbar with API integration
ClosedPublic

Authored by inidal on Jun 22 2023, 20:04.
Tags
None
Referenced Files
F2977401: D3205.diff
Wed, May 22, 13:05
F2976824: D3205.diff
Wed, May 22, 08:54
Unknown Object (File)
Mon, May 20, 23:27
Unknown Object (File)
Sun, May 19, 23:05
Unknown Object (File)
Sat, May 18, 14:14
Unknown Object (File)
Sat, May 18, 14:01
Unknown Object (File)
Sat, May 18, 05:58
Unknown Object (File)
Wed, May 15, 21:26
Subscribers
None

Details

Summary

This differential revision could serve as a reference to add a component
and an API functionality.

  • Add in-app config feature for the navbar
  • Add navbar component
  • Add API integration
  • Organize routes
  • Add HomeView file
  • Add .env.development with example
  • Fix indentation
  • Integrate Foundation Framework
  • Delete unwanted code

Diff Detail

Repository
rSP ServPulse
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inidal requested review of this revision.Jun 22 2023, 20:04
inidal created this revision.
dereckson requested changes to this revision.Jun 30 2023, 21:18
dereckson added inline comments.
frontend/servpulse-frontend/.env.development
2

If we use an environment here, it's evaluated at build time.

That means we need to build the application with injection of environment variables.

The API endpoint is a configuration used by the client. As such, it would be interesting to move this setting to a configuration file read by the JavaScript code executed in the browser.

frontend/servpulse-frontend/index.html
8

We don't take this opportunity to change the title?

frontend/servpulse-frontend/src/plugins/api.js
6

That will be solved when moving to a configuration.

This revision now requires changes to proceed.Jun 30 2023, 21:18
frontend/servpulse-frontend/index.html
8

I would prefer not to, but let's take care of this change during the SEO process. Additionally, we can make this tag dynamic by pulling data from the app's state.

frontend/servpulse-frontend/.env.development
2
frontend/servpulse-frontend/src/plugins/api.js
6

We should add a state to the app using Redux's store. This way, we can manage the data in a centralized manner and ensure that it is available across different components. We'll also be able to dispatch actions that updates the state and retrieve the updated data in our components. If this sounds good, let me know and I'll create a new ticket for it.

This revision is now accepted and ready to land.Jul 17 2023, 20:19

Per comments and discussions last weeks, we'll address the configuration store later.

This revision was automatically updated to reflect the committed changes.