Page MenuHomeDevCentral
Differential D333

APIClient and APIFactory contracts
ClosedPublic
Actions

Authored by dereckson on Mar 9 2016, 05:56.
Tags
None
Referenced Files
F11720148: D333.id1475.diff
Mon, Sep 15, 11:00
Unknown Object (File)
Sun, Sep 14, 11:38
Unknown Object (File)
Tue, Sep 9, 16:22
Unknown Object (File)
Tue, Sep 9, 16:22
Unknown Object (File)
Tue, Sep 9, 16:22
Unknown Object (File)
Tue, Sep 9, 16:22
Unknown Object (File)
Tue, Sep 9, 16:19
Unknown Object (File)
Tue, Sep 2, 07:12
View All Files
Subscribers
alken-orin

Details

Reviewers
dereckson
Commits
rNOTIFab12e8289918: APIClient and APIFactory contracts
Summary

To improve dependency injection in ProjectsMap, we create two
interface contracts, APIClient and APIFactory, which abstract
an API client and a class to instantiate them.

That allow to easily inject an API client and increase components
independance.

Test Plan

A variation of fea5b9c has successfully been tested.

Diff Detail

Repository
rNOTIF Notifications center
Lint
Lint Passed
Unit
Tests Passed
Branch
api-contracts

Event Timeline

dereckson updated this revision to Diff 793.Mar 9 2016, 05:56
dereckson retitled this revision from to APIClient and APIFactory contracts.
dereckson updated this object.
dereckson edited the test plan for this revision. (Show Details)
dereckson added a reviewer: dereckson.
alken-orin added a subscriber: alken-orin.Mar 9 2016, 05:57

Build started: https://ci.nasqueron.org/job/test-notifications-phab/118/ (console: https://ci.nasqueron.org/job/test-notifications-phab/118/console)

alken-orin added a comment.Mar 9 2016, 06:09

Build is green https://ci.nasqueron.org/job/test-notifications-phab/118/ for more details.

dereckson updated this revision to Diff 1475.Aug 10 2016, 19:17
dereckson edited edge metadata.

Rebased against master.

dereckson mentioned this in D334: API dependency injection for ProjectsMap.Aug 10 2016, 19:24
dereckson accepted this revision.Aug 10 2016, 19:47
dereckson edited edge metadata.
This revision is now accepted and ready to land.Aug 10 2016, 19:47
Closed by commit rNOTIFab12e8289918: APIClient and APIFactory contracts (authored by dereckson, committed by dereckson). · Explain WhyAug 10 2016, 19:49
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
app/
Contracts/
24 lines--
15 lines--
Phabricator/
34 lines--
4 lines100%
Loading...
29 lines91%
Loading...

Diff 793

View Options

app/Contracts/APIClient.php

Loading...
View Options

app/Contracts/APIFactory.php

Loading...
View Options

app/Phabricator/PhabricatorAPI.php

Loading...
View Options

app/Phabricator/PhabricatorAPIFactory.php

Loading...
View Options

app/Phabricator/ProjectsMap.php

Loading...
Nasqueron DevCentral · If it had been much bigger the moon would have had a core of ice. · Powered by Phabricator