Log some handled exceptions
ClosedPublic
Actions

Authored by dereckson on Mar 12 2016, 07:17.

Details

Reviewers

Commits

rNOTIFacc997591ebf: Log some handled exceptions

Summary

When events are fired in our application, some exceptions
are silently handled and reported as error in the actions
report.

This makes difficult to track these exceptions, as they
are logged in the requester app or silently discarded.

We so explicitely log them.

Diff Detail

Repository

rNOTIF Notifications center

Lint

Lint Passed

Unit

Tests Passed

Branch

log-exceptions

Event Timeline

dereckson updated this revision to Diff 802.Mar 12 2016, 07:17

dereckson retitled this revision from to WIP: log some handled exceptions.

dereckson updated this object.

dereckson edited the test plan for this revision. (Show Details)

dereckson retitled this revision from WIP: log some handled exceptions to Log some handled exceptions.Aug 14 2016, 20:38

Rebased against master.

Build is green https://ci.nasqueron.org/job/test-notifications-phab/151/ for more details.

dereckson accepted this revision.Aug 15 2016, 13:35

dereckson added a reviewer: dereckson.

This revision is now accepted and ready to land.Aug 15 2016, 13:35

Closed by commit rNOTIFacc997591ebf: Log some handled exceptions (authored by dereckson, committed by dereckson). · Explain WhyAug 15 2016, 13:37

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

app/

Jobs/

NotifyNewCommitsToDiffusion.php

2 lines

25%

SendMessageToBroker.php

2 lines

Diff 1495

View Options

app/Jobs/NotifyNewCommitsToDiffusion.php