Differential D3424

Extract SPARQL client
ClosedPublic
Actions

Authored by dereckson on Thu, Aug 29, 23:41.

Details

Reviewers

dereckson

Maniphest Tasks

T1752: Publish SPARQL client in Rust

Commits

rDSc74be4b99dd3: Extract SPARQL client

Summary

The sparql-client crate is based on oxigraph components
and extracted from fantoir-datasource crate.

The goal is to allow SPARQL queries in any Rust project.

As both fantoir-datasource and sparql-client needs
to build an HTTP client with specific configuration
(gzip, deflate, user-agent), common code previously
in fantoir-datasource is migrated to a specific support
crate, ds-http-client.

The ds- prefix has been chosen for small support libraries
for the datasources project.

Ref T1752

Test Plan

fetch file
run Wikidata enrichment

Diff Detail

Repository

rDS Nasqueron Datasources

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

extract-sparql-client

Build Status

Buildable 5458
Build 5739: arc lint + arc unit

Event Timeline

dereckson created this revision.Thu, Aug 29, 23:41

dereckson held this revision as a draft.

Harbormaster completed remote builds in B5456: Diff 8838.Thu, Aug 29, 23:41

dereckson added inline comments.Thu, Aug 29, 23:43

fantoir-datasource/src/commands/wikidata/mod.rs
49	There is a way here to inject Accept header. That would simplify a lot the code by removing the user agent dance.

Get rid of the HTTP client builder in sparql-client. Implement into_bool from P308. Add test for into_solutions.

Harbormaster completed remote builds in B5457: Diff 8839.Sat, Aug 31, 11:19

EOL at EOF, proofread new fantoir http_client

Harbormaster completed remote builds in B5458: Diff 8840.Sat, Aug 31, 11:24

HTTP client can still be used to fetch the .zip and send request to Wikidata.

SPARQL client still works fine.

dereckson accepted this revision.Sat, Aug 31, 14:26

This revision is now accepted and ready to land.Sat, Aug 31, 14:26

dereckson edited the summary of this revision. (Show Details)Sat, Aug 31, 14:32

Closed by commit rDSc74be4b99dd3: Extract SPARQL client (authored by dereckson). · Explain WhySat, Aug 31, 14:32

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rDSc74be4b99dd3: Extract SPARQL client.

Revision Contents
Changeset List

Path

Size

Cargo.toml

2 lines

ds-http-client/

Cargo.toml

15 lines

	ds-http-client/	src/	lib.rs/
	fantoir-datasource/	src/	services/


	http_client.rs

74 lines

fantoir-datasource/

Cargo.toml

9 lines

src/

commands/

fetch/

mod.rs

4 lines

wikidata/

mod.rs

9 lines

services/

104 lines

1 line

sparql-client/

18 lines

src/

lib.rs

252 lines

Diff 8840

View Options

Cargo.toml

View Options

ds-http-client/Cargo.toml

View Options

ds-http-client/src/lib.rs

View Options

fantoir-datasource/Cargo.toml

View Options

fantoir-datasource/src/commands/fetch/mod.rs

View Options

fantoir-datasource/src/commands/wikidata/mod.rs

View Options

fantoir-datasource/src/services/http_client.rs

View Options

fantoir-datasource/src/services/mod.rs

View Options

fantoir-datasource/src/services/sparql.rs

View Options

sparql-client/Cargo.toml

View Options

Extract SPARQL clientClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8840

Cargo.toml

ds-http-client/Cargo.toml

ds-http-client/src/lib.rs

fantoir-datasource/Cargo.toml

fantoir-datasource/src/commands/fetch/mod.rs

fantoir-datasource/src/commands/wikidata/mod.rs

fantoir-datasource/src/services/http_client.rs

fantoir-datasource/src/services/mod.rs

fantoir-datasource/src/services/sparql.rs

sparql-client/Cargo.toml

sparql-client/src/lib.rs

Extract SPARQL client
ClosedPublic
Actions

Revision Contents
Changeset List