Details

Reviewers

dereckson
DorianWinty

Summary

Based on rINFRAWWW
Reference: https://www.npmjs.com

The imagemin process now handle SVG, GIF and PNG. For JPEG, mozjpeg
supersedes jpegtran.

Dart Saas supersedes node-sass, as the reference SCSS implementation.

To make YAML loading safer, optional types like regexps
are extracted to a separate js-yaml-js-types package.

Signed-off-by: Sébastien Santoro <dereckson@espace-win.org>

Test Plan

Build a test site
make test

Diff Detail

Repository

rUPSECTION Upsection

Lint

Lint Passed

Unit

No Test Coverage

Branch

arcpatch-D3588

Build Status

Buildable 5724
Build 6006: arc lint + arc unit

Event Timeline

MoustaphaAs requested review of this revision.Wed, Nov 13, 12:34

MoustaphaAs created this revision.

Harbormaster completed remote builds in B5701: Diff 9248.Wed, Nov 13, 12:34

dereckson requested changes to this revision.Wed, Nov 13, 19:28

dereckson added inline comments.

package.json
13–14	This block should be updated too. Normally, if you run <code>make publish</code>, that should take care of this.

This revision now requires changes to proceed.Wed, Nov 13, 19:28

Update Foundation to 6.9.0

Harbormaster completed remote builds in B5702: Diff 9249.Thu, Nov 14, 10:57

Redirection of the gulfpipe test into /components/gulfpipe.js

Harbormaster completed remote builds in B5703: Diff 9250.Thu, Nov 14, 11:06

Keep only first commit

Harbormaster completed remote builds in B5705: Diff 9252.Thu, Nov 14, 11:56

MoustaphaAs added a child revision: D3590: Update Foundation to 6.9.0.Thu, Nov 14, 12:03

DorianWinty accepted this revision.Thu, Nov 14, 18:26

dereckson requested changes to this revision.Sat, Nov 16, 23:53

dereckson added inline comments.

components/gulpfile.js
140–149	[00:51:11] ReferenceError: imagemin is not defined at images …/gulpfile.babel.js:139:20)
144	Not aligned

This revision now requires changes to proceed.Sat, Nov 16, 23:53

MoustaphaAs updated this revision to Diff 9274.Wed, Nov 20, 11:15

This comment was removed by MoustaphaAs.

Harbormaster completed remote builds in B5720: Diff 9274.Wed, Nov 20, 11:15

Rebase

Harbormaster completed remote builds in B5723: Diff 9280.Wed, Nov 20, 21:21

MoustaphaAs edited the test plan for this revision. (Show Details)Wed, Nov 20, 21:36

Indentation and parsing error

Harbormaster completed remote builds in B5724: Diff 9281.Wed, Nov 20, 21:39

DorianWinty accepted this revision.Wed, Nov 20, 21:39

MoustaphaAs edited the summary of this revision. (Show Details)Wed, Nov 20, 21:51

MoustaphaAs edited the test plan for this revision. (Show Details)

space in import

Harbormaster completed remote builds in B5725: Diff 9282.Wed, Nov 20, 21:58

code style

Harbormaster completed remote builds in B5726: Diff 9283.Wed, Nov 20, 22:17

DorianWinty accepted this revision.Wed, Nov 20, 22:18

Update all the devdependencies
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 9281

components/gulpfile.js

package.json

Update all the devdependenciesNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 9281

components/gulpfile.js

package.json

Update all the devdependencies
Needs ReviewPublic
Actions

Revision Contents
Changeset List