Paths

Table of Contentst

Differential D3590

Update Foundation to 6.9.0
ClosedPublic
Actions

Authored by MoustaphaAs on Nov 14 2024, 12:00.

Tags

None

Referenced Files

	F3923192: D3590.id9299.diff
	Sat, Dec 21, 06:22

	F3923076: D3590.id9300.diff
	Sat, Dec 21, 05:55

	Unknown Object (File)
	Thu, Dec 19, 21:44

	Unknown Object (File)
	Thu, Dec 19, 21:38

	Unknown Object (File)
	Thu, Dec 19, 20:27

	Unknown Object (File)
	Thu, Dec 19, 19:52

	Unknown Object (File)
	Fri, Dec 13, 00:36

	Unknown Object (File)
	Tue, Dec 10, 10:41

View All 91 Files

Subscribers

None

Details

Reviewers

dereckson
DorianWinty

Commits

rUPSECTION0588b51369d4: Update Foundation to 6.9.0

Diff Detail

Repository

rUPSECTION Upsection

Lint

Lint Passed

Unit

No Test Coverage

Branch

localtunnel

Build Status

Buildable 5740
Build 6022: arc lint + arc unit

Event Timeline

MoustaphaAs requested review of this revision.Nov 14 2024, 12:00

MoustaphaAs created this revision.

Harbormaster completed remote builds in B5706: Diff 9253.Nov 14 2024, 12:00

MoustaphaAs added a parent revision: D3588: Update all the devdependencies.Nov 14 2024, 12:03

MoustaphaAs added a reviewer: dereckson.

DorianWinty accepted this revision.Nov 14 2024, 18:27

This revision is now accepted and ready to land.Nov 14 2024, 18:27

dereckson requested changes to this revision.Nov 16 2024, 23:42

dereckson added inline comments.

template/src/assets/scss/_settings.scss
884	If this is now 57, what's the 56?

This revision now requires changes to proceed.Nov 16 2024, 23:42

It's the 56 lapse of attention

Harbormaster completed remote builds in B5719: Diff 9273.Nov 20 2024, 10:32

Using git bisect on foundation-sites repository, the 6.8.0 introduced a new section 56 "untitled" with a null primary color, pushing Xy Grid from 56 to 57, fixed afterwards by removing that extra section.

477b172480e6263c6f29315cc52a26c02cb56869 is the first bad commit
commit 477b172480e6263c6f29315cc52a26c02cb56869
Author: Joe Workman <joe@workmanmail.com>
Date:   Thu Aug 17 20:40:45 2023 -0700

    6.8.0 version bump

You can fix that by committing upstream a change in foundation/foundation-sites repository.

Revision

Harbormaster completed remote builds in B5729: Diff 9287.Fri, Nov 22, 12:05

Revision

Harbormaster completed remote builds in B5730: Diff 9288.Fri, Nov 22, 12:08

Revision

Harbormaster completed remote builds in B5731: Diff 9289.Fri, Nov 22, 12:11

Revision

Harbormaster completed remote builds in B5732: Diff 9290.Fri, Nov 22, 12:22

Rebase

Harbormaster completed remote builds in B5733: Diff 9291.Fri, Nov 22, 14:06

Rebase

Harbormaster completed remote builds in B5734: Diff 9292.Fri, Nov 22, 14:38

Rebase

Harbormaster completed remote builds in B5737: Diff 9296.Fri, Nov 22, 16:33

Rebase

Harbormaster completed remote builds in B5738: Diff 9297.Fri, Nov 22, 16:37

Revision

Harbormaster completed remote builds in B5739: Diff 9298.Fri, Nov 22, 16:39

MoustaphaAs updated this revision to Diff 9299.Wed, Nov 27, 10:02

This comment was removed by MoustaphaAs.

Harbormaster completed remote builds in B5740: Diff 9299.Wed, Nov 27, 10:02

Update Foundation

Harbormaster completed remote builds in B5741: Diff 9300.Wed, Nov 27, 10:12

dereckson accepted this revision.Wed, Nov 27, 17:15

This revision is now accepted and ready to land.Wed, Nov 27, 17:15

Closed by commit rUPSECTION0588b51369d4: Update Foundation to 6.9.0 (authored by MoustaphaAs). · Explain WhyWed, Nov 27, 17:18

This revision was automatically updated to reflect the committed changes.

MoustaphaAs added a commit: rUPSECTION0588b51369d4: Update Foundation to 6.9.0.

MoustaphaAs mentioned this in D3596: Update all the devdependencies.Thu, Nov 28, 14:26

Revision Contents
Changeset List

Path

Size

components/

27 lines

package-template.json

3 lines

1 line

template/

2 lines

src/

assets/

scss/

60 lines

Diff 9299

components/gulpfile.js

Loading...

components/package-template.json

Loading...

config.yml

Loading...

template/Makefile

Loading...

template/src/assets/scss/_settings.scss

Loading...