Differential D3758

Avoid reserved name get_resource_id
ClosedPublic
Actions

Authored by dereckson on Fri, Oct 17, 20:20.

Details

Reviewers

dereckson

Maniphest Tasks

T2144: Port Obsidian code to PHP 8.4

Commits

rOBSIDIAN5aafe87ceb27: Avoid reserved name get_resource_id

Summary

PHP 8 has introduced a new function using the same name.

Ref T2144

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

main

Build Status

Buildable 6023
Build 6307: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Fri, Oct 17, 20:20

dereckson created this revision.

Harbormaster completed remote builds in B6023: Diff 9736.Fri, Oct 17, 20:20

dereckson accepted this revision.Fri, Oct 17, 20:21

This revision is now accepted and ready to land.Fri, Oct 17, 20:21

Closed by commit rOBSIDIAN5aafe87ceb27: Avoid reserved name get_resource_id (authored by dereckson). · Explain WhyFri, Oct 17, 20:47

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIAN5aafe87ceb27: Avoid reserved name get_resource_id.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

includes/

GlobalFunctions.php

2 lines

auth/

GivePermissionUserAction.php

2 lines

Diff 9736

View Options

workspaces/src/includes/GlobalFunctions.php