Differential D3862

Refactor Workspace::get_user_workspaces
ClosedPublic
Actions

Authored by dereckson on Mon, Nov 10, 02:34.

Tags

None

Referenced Files

	F12591204: D3862.diff
	Tue, Nov 11, 18:21

Subscribers

None

Details

Reviewers

Commits

rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces

Summary

With a void cache, the null value returned by the cache was passed to unserialize code.

While this issue was left aside to replace current caches classes by keruald/cache,
the function can already be split between cache/database query/build object methods.

This fixes the following issue:
[09-Nov-2025 16:47:46 UTC] PHP Deprecated:
unserialize(): Passing null to parameter #1 ($data) of type string is deprecated
in /var/51-wwwroot/obsidian/workspaces/src/Engines/Workspaces/Workspace.php on line 229

Test Plan

Check if the list in navbar header still contains workspaces.

Diff Detail

Repository

rOBSIDIAN Obsidian Workspaces

Lint

No Lint Coverage

Unit

No Test Coverage

Branch

main

Build Status

Buildable 6165
Build 6449: arc lint + arc unit

Event Timeline

dereckson requested review of this revision.Mon, Nov 10, 02:34

dereckson created this revision.

Harbormaster completed remote builds in B6165: Diff 10001.Mon, Nov 10, 02:34

dereckson accepted this revision.Mon, Nov 10, 02:36

This revision is now accepted and ready to land.Mon, Nov 10, 02:36

Closed by commit rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces (authored by dereckson). · Explain WhyMon, Nov 10, 02:36

This revision was automatically updated to reflect the committed changes.

dereckson added a commit: rOBSIDIANe015a94a4aae: Refactor Workspace::get_user_workspaces.

Revision Contents
Changeset List

Path

Size

workspaces/

src/

Engines/

Workspaces/

69 lines

Diff 10001

workspaces/src/Engines/Workspaces/Workspace.php

Loading...